Open
Conversation
Contributor
|
Looks good! Could you add/update the zarr tests to demonstrate/prevent regression? |
r2dliu
force-pushed
the
fix/ome-zarr-omero-metadata-v05
branch
from
6b4ac87 to
8fe6dad
Compare
Author
|
I added omero data to both datasets. Validated that removing the fix caused the regression and broke the existing tests |
Collaborator
|
Please also update the generate_ome_zarr.py script rather than manually editing the generated examples. |
Author
|
Missed that somehow, sorry |
Contributor
|
@jbms can you we get the workflows enabled for this PR? |
Contributor
|
@jbms should we remove these generated files from vsc and have it run JIT? Or a warning to manually run it if the files are missing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed channel names weren't loading correctly from the metadata in my OME-Zarr 0.5 datasets so found a couple of bugs.
parseOmeroChannelfires (was being skipped before since metadata wasn't being read) and crashes onparseRGBColorSpecification. Made more defensive to prevent this