Skip to content

Conversation

@aditya-goyal01
Copy link
Contributor

@aditya-goyal01 aditya-goyal01 commented Oct 31, 2025

Issue

https://gravitee.atlassian.net/browse/APIM-10361

Description

The Pull Request removes the now-deprecated PathParametersValidationService and replaces its usage with the existing FlowValidationDomainService. The changes modernize validation logic to detect overlaps in path parameters more efficiently.

  • Replaced Service: All instances of PathParametersValidationService are replaced with FlowValidationDomainService.
  • Removed Dead Code: Deleted all implementations and tests related to PathParametersValidationService.
  • Updated Logic: Introduced improved methods for path normalization and ambiguity detection in FlowValidationDomainService.
  • Updated Tests: Adjusted and removed test cases to align with the new service. Deleted obsolete test resources related to the deprecated service.

Test

Additional context

@aditya-goyal01 aditya-goyal01 force-pushed the apim-10361-valid-open-api-paths-rejected-while-importing branch 2 times, most recently from ce3b806 to 0fe4975 Compare November 3, 2025 08:53
@aditya-goyal01 aditya-goyal01 marked this pull request as ready for review November 3, 2025 09:47
@aditya-goyal01 aditya-goyal01 requested a review from a team as a code owner November 3, 2025 09:47
@aditya-goyal01 aditya-goyal01 force-pushed the apim-10361-valid-open-api-paths-rejected-while-importing branch 2 times, most recently from 0d6bcf8 to ffbf1ef Compare November 3, 2025 12:44
@aditya-goyal01 aditya-goyal01 changed the title fix(console): correction in find overlapping paths while importing apis fix(console): valid open api paths rejected while importing v4 apis Nov 3, 2025
@aditya-goyal01 aditya-goyal01 force-pushed the apim-10361-valid-open-api-paths-rejected-while-importing branch 3 times, most recently from 2fce7ed to 8f00fc2 Compare November 3, 2025 14:52
@phiz71
Copy link
Member

phiz71 commented Nov 4, 2025

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully replaces the deprecated PathParametersValidationService with FlowValidationDomainService, introducing a more robust path parameter validation logic that correctly handles OpenAPI path templating ambiguities. The new implementation is a significant improvement and correctly addresses the issue of rejecting valid OpenAPI specifications. I've provided a couple of suggestions in FlowValidationDomainService to further enhance the new logic's performance and readability. The removal of old code and tests is clean. Overall, this is a great enhancement.

@aditya-goyal01 aditya-goyal01 force-pushed the apim-10361-valid-open-api-paths-rejected-while-importing branch 2 times, most recently from a7eb282 to e55e009 Compare November 5, 2025 09:49
fix(console): remove deprecated class
@aditya-goyal01 aditya-goyal01 force-pushed the apim-10361-valid-open-api-paths-rejected-while-importing branch from e55e009 to eeba4a4 Compare November 5, 2025 10:13
@aditya-goyal01 aditya-goyal01 merged commit 90a3eea into master Nov 5, 2025
12 checks passed
@aditya-goyal01 aditya-goyal01 deleted the apim-10361-valid-open-api-paths-rejected-while-importing branch November 5, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants