chore: Grant admin rights to holochain-devs#45
Closed
ThetaSinner wants to merge 1 commit intomainfrom
Closed
Conversation
|
✔️ f298dea - Conventional commits check succeeded. |
🍹
|
cdunster
reviewed
Jun 27, 2025
| _, err = github.NewTeamRepository(ctx, fmt.Sprintf("%s-collaborator-holochain-devs", name), &github.TeamRepositoryArgs{ | ||
| Repository: repository.Name, | ||
| Permission: pulumi.String("maintain"), | ||
| Permission: pulumi.String("admin"), |
Contributor
There was a problem hiding this comment.
Why is this needed? Shouldn't most of the management of Holochain repos be done through this repo, meaning that we don't need to make individual admin changes?
Member
Author
There was a problem hiding this comment.
That's fair, we could try to do without it. I do usually need to make changes manually to figure out what settings we can change before doing it through Pulumi but otherwise we could maybe make do with maintain permissions.
The reason I'm changing this is that I just reduced the core-dev to minimal users because in theory we no longer need as many permissions and so we should still be admins through the actual dev group now.
Contributor
There was a problem hiding this comment.
Yeah, I get wanting to try it out before making the changes through Pulumi, but I worry about what we lose with that, especially for new members who might not know about this repo and just make direct changes if they have the permissions to do so.
I feel like, for the number of times that we need to make these changes, I'd rather keep the extra steps and with it the protections we get. Then we can keep the group of actual admins very small.
All that being said I am happy to approve this change if you think it's for the best. 🙂
Member
Author
There was a problem hiding this comment.
Well I'm the maintainer of the group that has the hra2 account it it and gets permissions to publish on crates.io. If we want to try doing without admin permissions then let's give it a go and see how long it takes for that to get annoying :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.