Skip to content

chore: Grant admin rights to holochain-devs #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ThetaSinner wants to merge 1 commit into from
Closed

chore: Grant admin rights to holochain-devs #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1230,7 +1230,7 @@ func StandardRepositoryAccess(ctx *pulumi.Context, name string, repository *gith
}
_, err = github.NewTeamRepository(ctx, fmt.Sprintf("%s-collaborator-holochain-devs", name), &github.TeamRepositoryArgs{
Repository: repository.Name,
Permission: pulumi.String("maintain"),
Permission: pulumi.String("admin"),
Copy link
Copy Markdown
Contributor

@cdunster cdunster Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? Shouldn't most of the management of Holochain repos be done through this repo, meaning that we don't need to make individual admin changes?

Copy link
Copy Markdown
Member Author

@ThetaSinner ThetaSinner Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair, we could try to do without it. I do usually need to make changes manually to figure out what settings we can change before doing it through Pulumi but otherwise we could maybe make do with maintain permissions.

The reason I'm changing this is that I just reduced the core-dev to minimal users because in theory we no longer need as many permissions and so we should still be admins through the actual dev group now.

Copy link
Copy Markdown
Contributor

@cdunster cdunster Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I get wanting to try it out before making the changes through Pulumi, but I worry about what we lose with that, especially for new members who might not know about this repo and just make direct changes if they have the permissions to do so.

I feel like, for the number of times that we need to make these changes, I'd rather keep the extra steps and with it the protections we get. Then we can keep the group of actual admins very small.

All that being said I am happy to approve this change if you think it's for the best. 🙂

Copy link
Copy Markdown
Member Author

@ThetaSinner ThetaSinner Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I'm the maintainer of the group that has the hra2 account it it and gets permissions to publish on crates.io. If we want to try doing without admin permissions then let's give it a go and see how long it takes for that to get annoying :D

TeamId: pulumi.String("holochain-devs"),
})

Expand Down