Skip to content

Show file size depend on the OS #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Gao-Jun wants to merge 1 commit into from
Closed

Show file size depend on the OS #1810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions app/coffeescripts/util/friendlyBytes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,26 @@

import I18n from 'i18nObj'

const units = ['byte', 'bytes', 'KB', 'MB', 'GB', 'TB']
const decimalUnits = ['byte', 'bytes', 'KB', 'MB', 'GB', 'TB']
const binaryUnits = ['byte', 'bytes', 'KiB', 'MiB', 'GiB', 'TiB']

// converts bytes into a nice representation with unit. e.g. 13661855 -> 13.7 MB, 825399 -> 825 KB, 1396 -> 1 KB
// converts bytes into a nice representation with unit according to user's OS
// for Mac OS users, 13661855 -> 13.7 MB, 825399 -> 825 KB, 1396 -> 1 KB
// for other users, 13661855 -> 13 MiB, 825399 -> 806 KiB, 1396 -> 1KiB
export default function friendlyBytes(value) {
let resInt, resValue
const bytes = parseInt(value, 10)
if (bytes.toString() === 'NaN') return '--'

const isMac = navigator.userAgent.includes('Mac')
const frac = isMac ? 1000 : 1024
const units = isMac ? decimalUnits : binaryUnits

if (bytes === 0) {
resInt = resValue = 0
} else {
resInt = Math.floor(Math.log(bytes) / Math.log(1000)) // base 10 (rather than 1024) matches Mac OS X
resValue = (bytes / Math.pow(1000, Math.floor(resInt))).toFixed(resInt < 2 ? 0 : 1) // no decimals for anything smaller than 1 MB
resInt = Math.floor(Math.log(bytes) / Math.log(frac))
resValue = (bytes / Math.pow(frac, Math.floor(resInt))).toFixed(resInt < 2 ? 0 : 1) // no decimals for anything smaller than 1 MB
if (bytes === 1) resInt = -1 // 1 byte special case
}

Expand Down