Show file size depend on the OS#1810
Closed
Gao-Jun wants to merge 1 commit intoinstructure:masterfrom
Closed
Conversation
1 MB = 1000 Bytes for Mac user, and 1MiB = 1024 Bytes for others
Contributor
|
Hi @Gao-Jun Sorry this has not been addressed in some time. We are working on getting to things much quicker now. This file has been moved and thus this PR is no longer valid. If you wanted to update it I could work on getting it reviewed. |
Contributor
Author
|
Hi @dustin-cowles An updated version of this PR is here #2367 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One day, a Windows user asked, why I got a smaller file downloaded (806K) compared with the size shown in 'Files'(825K) ? Is the file downloaded completely?
In Mac OS, 1 KB = 1000 Bytes. In Windows and Linux, 1 MB = 1024 Bytes
This patch will display the file size depend on the OS.
In detail, 1 MB = 1000 Bytes for Mac user, and 1MiB = 1024 Bytes for others