Skip to content

Show file size depend on the OS#2367

Open
Gao-Jun wants to merge 1 commit intoinstructure:masterfrom
Fudan-University:more_friendly_bytes
Open

Show file size depend on the OS#2367
Gao-Jun wants to merge 1 commit intoinstructure:masterfrom
Fudan-University:more_friendly_bytes

Conversation

@Gao-Jun
Copy link
Contributor

@Gao-Jun Gao-Jun commented Jun 12, 2024

This PR is an updated version of #1810

One day, a Windows user asked, why I got a smaller file downloaded (806K) compared with the size shown in 'Files'(825K) ? Is the file downloaded completely?

In Mac OS, 1 KB = 1000 Bytes. In Windows and Linux, 1 MB = 1024 Bytes

This patch will display the file size depend on the OS.

In detail, 1 MB = 1000 Bytes for Mac user, and 1MiB = 1024 Bytes for others

1 MB = 1000 Bytes for Mac user, and 1MiB = 1024 Bytes for others
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants