Exit when backupsink stopped also fix NPE when negative offset #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
discanto
changed the title
Author
|
The NPE can happen when there is a consumer-group without a topic, even adminclient < 2.4.1 fails to describe such a group, see the fix for it here https://issues.apache.org/jira/browse/KAFKA-9507. Only deleting such consumer-groups can allow kafka-backup to proceed. |
itadventurer
requested changes
Aug 16, 2020
Owner
itadventurer
left a comment
itadventurer
left a comment
There was a problem hiding this comment.
Thanks for the PR! I think we should split it in two PRs and I do not fully understand whether it is ok to simply continue when we encounter the linked issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No point in keeping the process going when the BackupSinkTask is killed.
Exiting will allow monitoring/daemon systems to restart or otherwise take action on all the RuntimeExceptions thrown.