Skip to content

Exit when backupsink stopped also fix NPE when negative offset #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Exit when backupsink stopped also fix NPE when negative offset #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/main/java/de/azapps/kafkabackup/common/offset/OffsetSink.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
package de.azapps.kafkabackup.common.offset;

import com.fasterxml.jackson.databind.ObjectMapper;
import de.azapps.kafkabackup.sink.BackupSinkTask;
import org.apache.kafka.clients.admin.AdminClient;
import org.apache.kafka.clients.admin.ConsumerGroupListing;
import org.apache.kafka.clients.consumer.OffsetAndMetadata;
import org.apache.kafka.common.TopicPartition;
import org.apache.kafka.connect.errors.RetriableException;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import java.io.IOException;
import java.nio.file.Files;
Expand All @@ -19,6 +22,7 @@
import java.util.stream.Collectors;

public class OffsetSink {
private static final Logger log = LoggerFactory.getLogger(OffsetSink.class);
private final Path targetDir;
private final Map<TopicPartition, OffsetStoreFile> topicOffsets = new HashMap<>();
private List<String> consumerGroups = new ArrayList<>();
Expand Down Expand Up @@ -62,6 +66,10 @@ private void syncOffsetsForGroup(String consumerGroup) throws IOException {
for (Map.Entry<TopicPartition, OffsetAndMetadata> entry : topicOffsetsAndMetadata.entrySet()) {
TopicPartition tp = entry.getKey();
OffsetAndMetadata offsetAndMetadata = entry.getValue();
if (offsetAndMetadata == null) {
log.warn("OffsetAndMetadata not available, negative offset? for tp {}", tp);
return;
}

if (validTopic(tp.topic())) {
if (!this.topicOffsets.containsKey(tp)) {
Expand Down