Introduce Skills Framework Scaffold#8151
Open
hharshhsaini wants to merge 2 commits intojaegertracing:mainfrom
Open
Introduce Skills Framework Scaffold#8151hharshhsaini wants to merge 2 commits intojaegertracing:mainfrom
hharshhsaini wants to merge 2 commits intojaegertracing:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces a new internal skills scaffold for the Jaeger MCP extension, including a YAML-based skill definition model, directory loader, and in-memory registry intended to support future agent/skills functionality without LLM dependencies.
Changes:
- Added
Skill/SkillTooldata model for YAML-backed skill definitions. - Added
LoadSkillsYAML loader to discover and validate skills from a directory with zap logging. - Added an in-memory
Registrywith unit tests and sample skill YAML intestdata.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Promotes gopkg.in/yaml.v3 to a direct dependency for the new YAML loader. |
| cmd/jaeger/internal/extension/jaegermcp/internal/skills/skills.go | Defines Skill and SkillTool structs with YAML tags. |
| cmd/jaeger/internal/extension/jaegermcp/internal/skills/loader.go | Implements directory discovery + YAML parsing + minimal validation for skills. |
| cmd/jaeger/internal/extension/jaegermcp/internal/skills/registry.go | Adds a mutex-protected in-memory registry for loaded skills. |
| cmd/jaeger/internal/extension/jaegermcp/internal/skills/loader_test.go | Adds unit tests for basic loader scenarios. |
| cmd/jaeger/internal/extension/jaegermcp/internal/skills/registry_test.go | Adds unit tests for registry operations. |
| cmd/jaeger/internal/extension/jaegermcp/internal/skills/package_test.go | Adds leak verification TestMain for the package. |
| cmd/jaeger/internal/extension/jaegermcp/internal/skills/testdata/skills/critical_path_analyzer.yaml | Adds an example skill YAML for testing and reference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cmd/jaeger/internal/extension/jaegermcp/internal/skills/package_test.go
Outdated
Show resolved
Hide resolved
024ee49 to
c66bd76
Compare
This PR introduces the foundational Skills Framework scaffold for the Jaeger AI agent. It defines the Skill data model, a YAML-based loader that dynamically discovers skills from a configurable directory without recompilation, and an in-memory registry. No AI/LLM dependencies are introduced in this PR. Follows patterns established by jaegerquery extension. Signed-off-by: hharshhsaini <sainiharsh3311@gmail.com>
Signed-off-by: hharshhsaini <sainiharsh3311@gmail.com>
c66bd76 to
43c398e
Compare
Member
|
not accepting PRs without overall design agreed upfront |
Contributor
Author
@yurishkuro yes sir , I am working on the complete Design of the project , will Raise the PR for it ASAP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the foundational Skills Framework scaffold for the Jaeger AI agent. It defines the Skill data model, a YAML-based loader that dynamically discovers skills from a configurable directory without recompilation, and an in-memory registry. No AI/LLM dependencies are introduced in this PR. Follows patterns established by jaegerquery extension.
Which problem is this PR solving?
Description of the changes
SkillandSkillToolstructs.loaderwith validation andzaplogging for discovering skills.Registry.loader_test.goandregistry_test.go) covering valid and fallback scenarios.testdata/skills/critical_path_analyzer.yaml.How was this change tested?
go test -v ./...insidecmd/jaeger/internal/extension/jaegermcp/internal/skills(100% passing tests).make lint.testutils.VerifyGoLeaks.Checklist
make lint testAI Usage in this PR (choose one)
See AI Usage Policy.