Skip to content

Introduce Skills Framework Scaffold#8151

Open
hharshhsaini wants to merge 2 commits intojaegertracing:mainfrom
hharshhsaini:ai/skills-framework-scaffold
Open

Introduce Skills Framework Scaffold#8151
hharshhsaini wants to merge 2 commits intojaegertracing:mainfrom
hharshhsaini:ai/skills-framework-scaffold

Conversation

@hharshhsaini
Copy link
Contributor

@hharshhsaini hharshhsaini commented Mar 8, 2026

This PR introduces the foundational Skills Framework scaffold for the Jaeger AI agent. It defines the Skill data model, a YAML-based loader that dynamically discovers skills from a configurable directory without recompilation, and an in-memory registry. No AI/LLM dependencies are introduced in this PR. Follows patterns established by jaegerquery extension.

Which problem is this PR solving?

Description of the changes

  • Introduces Skill and SkillTool structs.
  • Implements a dynamic YAML loader with validation and zap logging for discovering skills.
  • Implements an in-memory skills Registry.
  • Adds comprehensive unit testing (loader_test.go and registry_test.go) covering valid and fallback scenarios.
  • Adds an example testing skill at testdata/skills/critical_path_analyzer.yaml.

How was this change tested?

  • Unit tests run using go test -v ./... inside cmd/jaeger/internal/extension/jaegermcp/internal/skills (100% passing tests).
  • All lints validated locally via make lint.
  • Verified no goroutine leaks with Jaeger's testutils.VerifyGoLeaks.

Checklist

AI Usage in this PR (choose one)

See AI Usage Policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Copilot AI review requested due to automatic review settings March 8, 2026 14:20
@hharshhsaini hharshhsaini requested a review from a team as a code owner March 8, 2026 14:20
@dosubot dosubot bot added the enhancement label Mar 8, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Introduces a new internal skills scaffold for the Jaeger MCP extension, including a YAML-based skill definition model, directory loader, and in-memory registry intended to support future agent/skills functionality without LLM dependencies.

Changes:

  • Added Skill / SkillTool data model for YAML-backed skill definitions.
  • Added LoadSkills YAML loader to discover and validate skills from a directory with zap logging.
  • Added an in-memory Registry with unit tests and sample skill YAML in testdata.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
go.mod Promotes gopkg.in/yaml.v3 to a direct dependency for the new YAML loader.
cmd/jaeger/internal/extension/jaegermcp/internal/skills/skills.go Defines Skill and SkillTool structs with YAML tags.
cmd/jaeger/internal/extension/jaegermcp/internal/skills/loader.go Implements directory discovery + YAML parsing + minimal validation for skills.
cmd/jaeger/internal/extension/jaegermcp/internal/skills/registry.go Adds a mutex-protected in-memory registry for loaded skills.
cmd/jaeger/internal/extension/jaegermcp/internal/skills/loader_test.go Adds unit tests for basic loader scenarios.
cmd/jaeger/internal/extension/jaegermcp/internal/skills/registry_test.go Adds unit tests for registry operations.
cmd/jaeger/internal/extension/jaegermcp/internal/skills/package_test.go Adds leak verification TestMain for the package.
cmd/jaeger/internal/extension/jaegermcp/internal/skills/testdata/skills/critical_path_analyzer.yaml Adds an example skill YAML for testing and reference.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hharshhsaini hharshhsaini force-pushed the ai/skills-framework-scaffold branch from 024ee49 to c66bd76 Compare March 8, 2026 14:37
This PR introduces the foundational Skills Framework scaffold for the Jaeger AI agent. It defines the Skill data model, a YAML-based loader that dynamically discovers skills from a configurable directory without recompilation, and an in-memory registry. No AI/LLM dependencies are introduced in this PR. Follows patterns established by jaegerquery extension.

Signed-off-by: hharshhsaini <sainiharsh3311@gmail.com>
Signed-off-by: hharshhsaini <sainiharsh3311@gmail.com>
@hharshhsaini hharshhsaini force-pushed the ai/skills-framework-scaffold branch from c66bd76 to 43c398e Compare March 8, 2026 15:01
@yurishkuro
Copy link
Member

not accepting PRs without overall design agreed upfront

@github-actions github-actions bot added the waiting-for-author PR is waiting for author to respond to maintainer's comments label Mar 9, 2026
@hharshhsaini
Copy link
Contributor Author

not accepting PRs without overall design agreed upfront

@yurishkuro yes sir , I am working on the complete Design of the project , will Raise the PR for it ASAP.

@github-actions github-actions bot removed the waiting-for-author PR is waiting for author to respond to maintainer's comments label Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants