Skip to content

test: remove redundant TestGetTraceWithRawTracesParameter#8155

Open
aliyasirnac wants to merge 1 commit intojaegertracing:mainfrom
aliyasirnac:feat-extend-test-case
Open

test: remove redundant TestGetTraceWithRawTracesParameter#8155
aliyasirnac wants to merge 1 commit intojaegertracing:mainfrom
aliyasirnac:feat-extend-test-case

Conversation

@aliyasirnac
Copy link

@aliyasirnac aliyasirnac commented Mar 9, 2026

Which problem is this PR solving?

  • Resolves a stale // TODO in http_handler_test.go. The test logic for the raw parameter was already implemented in TestGetTrace, making TestGetTraceWithRawTracesParameter redundant.

Description of the changes

  • Removed TestGetTraceWithRawTracesParameter entirely.
  • The raw query parameter behavior (asserting that raw=true yields 3 spans and raw=false yields 2 spans via deduplication) is already adequately covered by the existing TestGetTrace test earlier in the same file. Removing this function eliminates code duplication and reduces maintenance cost.

How was this change tested?

  • Verified that make test and make lint still pass successfully without the redundant test.

Checklist

AI Usage in this PR (choose one)

SeeAI Usage Policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Copilot AI review requested due to automatic review settings March 9, 2026 18:39
@aliyasirnac aliyasirnac requested a review from a team as a code owner March 9, 2026 18:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Extends Jaeger Query HTTP handler tests to validate the behavioral difference of fetching traces with and without the raw query parameter, specifically around span adjustment/deduplication.

Changes:

  • Replaces the previous TODO-only TestGetTraceWithRawTracesParameter with an actual assertion using a trace containing a duplicate span.
  • Converts the test to a table-driven form to validate both raw=true and raw=false cases via expected span counts.
  • Validates the decoded JSON response contains the expected number of spans.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aliyasirnac aliyasirnac force-pushed the feat-extend-test-case branch from 1ceaad6 to bdf7c4a Compare March 9, 2026 18:48
@aliyasirnac aliyasirnac changed the title test: extend GetTraceWithRawTracesParameter to verify span deduplication based on the raw parameter test: remove redundant TestGetTraceWithRawTracesParameter Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants