test: remove redundant TestGetTraceWithRawTracesParameter#8155
Open
aliyasirnac wants to merge 1 commit intojaegertracing:mainfrom
Open
test: remove redundant TestGetTraceWithRawTracesParameter#8155aliyasirnac wants to merge 1 commit intojaegertracing:mainfrom
aliyasirnac wants to merge 1 commit intojaegertracing:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Extends Jaeger Query HTTP handler tests to validate the behavioral difference of fetching traces with and without the raw query parameter, specifically around span adjustment/deduplication.
Changes:
- Replaces the previous TODO-only
TestGetTraceWithRawTracesParameterwith an actual assertion using a trace containing a duplicate span. - Converts the test to a table-driven form to validate both
raw=trueandraw=falsecases via expected span counts. - Validates the decoded JSON response contains the expected number of spans.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cmd/jaeger/internal/extension/jaegerquery/internal/http_handler_test.go
Outdated
Show resolved
Hide resolved
1ceaad6 to
bdf7c4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
// TODOinhttp_handler_test.go. The test logic for therawparameter was already implemented inTestGetTrace, makingTestGetTraceWithRawTracesParameterredundant.Description of the changes
TestGetTraceWithRawTracesParameterentirely.rawquery parameter behavior (asserting thatraw=trueyields 3 spans andraw=falseyields 2 spans via deduplication) is already adequately covered by the existingTestGetTracetest earlier in the same file. Removing this function eliminates code duplication and reduces maintenance cost.How was this change tested?
make testandmake lintstill pass successfully without the redundant test.Checklist
make lint testAI Usage in this PR (choose one)
SeeAI Usage Policy.