Skip to content

test: remove redundant TestGetTraceWithRawTracesParameter #8155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aliyasirnac wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: remove redundant TestGetTraceWithRawTracesParameter #8155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions cmd/jaeger/internal/extension/jaegerquery/internal/http_handler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,30 +446,6 @@ func TestGetTraceBadTimeWindow(t *testing.T) {
}
}

func TestGetTraceWithRawTracesParameter(t *testing.T) {
// TODO: extend the test cases to ensure raw traces are obtained
// when the flag is set once the differentiating logic has been implemented
tests := []struct {
rawTraces bool
}{
{rawTraces: true},
{rawTraces: false},
}
for _, test := range tests {
t.Run(fmt.Sprintf("rawTraces=%v", test.rawTraces), func(t *testing.T) {
ts := initializeTestServer(t)
ts.traceReader.On("GetTraces", mock.Anything, mock.MatchedBy(func(params []tracestore.GetTraceParams) bool {
return len(params) == 1 && params[0].TraceID == v1adapter.FromV1TraceID(mockTraceID)
})).Return(tracesIter(makeMockPTrace())).Once()

var response structuredResponse
err := getJSON(fmt.Sprintf("%s/api/traces/%s?raw=%v", ts.server.URL, mockTraceID.String(), test.rawTraces), &response)
require.NoError(t, err)
assert.Empty(t, response.Errors)
})
}
}

func TestGetTraceBadRawTracesFlag(t *testing.T) {
ts := initializeTestServer(t)
var response structuredResponse
Expand Down