clickhouse(depstore): return error instead of panic in GetDependencies

[jkowall]

Motivation

• The ClickHouse storage backend is selectable and its dependency reader previously used panic("not implemented"), which can crash the query service when invoked and cause a DoS. This change prevents process termination by returning an error.

Description

• Replace the panic in (*Reader).GetDependencies with a returned error.
• Update the unit test in internal/storage/v2/clickhouse/depstore/reader_test.go to assert a nil result and the expected error instead of expecting a panic.

Testing

• make fmt
• make lint
• make test

[Copilot]

Pull request overview

This PR replaces a runtime panic in the ClickHouse dependency reader with a regular error return, and updates the unit test accordingly. This aligns the ClickHouse depstore implementation with safer, production-friendly behavior when a feature is not yet implemented.

Changes:

• Replace panic("not implemented") in GetDependencies with an error return.
• Update the dependency reader test to assert on the returned error and nil dependencies.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
internal/storage/v2/clickhouse/depstore/reader.go	Return a non-panicking “not implemented” error from GetDependencies.
internal/storage/v2/clickhouse/depstore/reader_test.go	Update test to validate the error return instead of expecting a panic.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[yurishkuro]

commits not signed?