feat(ci): add metrics snapshot to tailsampling E2E workflow#8190
feat(ci): add metrics snapshot to tailsampling E2E workflow#8190hharshhsaini wants to merge 1 commit intojaegertracing:mainfrom
Conversation
Add verify-metrics-snapshot action step to ci-e2e-tailsampling.yml. The tail sampling test uses E2EStorageIntegration.e2eInitialize(), which automatically scrapes Jaeger metrics at test cleanup and writes them to .metrics/metrics_snapshot_<storage>.txt. Updated the storage label from "memory" to "tailsampling" so the snapshot gets a unique name (metrics_snapshot_tailsampling.txt) that does not conflict with the memory workflow's snapshot. Part of jaegertracing#6278. Signed-off-by: hharshhsaini <sainiharsh3311@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the tail sampling processor integration tests to capture and verify metrics snapshots. It makes two coordinated changes: updating the test to use "tailsampling" as the identifier for metrics snapshots, and adding the metrics snapshot verification step to the CI workflow.
Changes:
- Changed the storage parameter in the tail sampling test from "memory" to "tailsampling" to provide a distinct metrics snapshot identifier for tail sampling tests
- Added metrics snapshot verification step to the tail sampling CI workflow
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmd/jaeger/internal/integration/tailsampling_test.go | Updated storage parameter to "tailsampling" for metrics snapshot naming |
| .github/workflows/ci-e2e-tailsampling.yml | Added metrics snapshot verification step to match the test's metrics snapshot identifier |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8190 +/- ##
==========================================
- Coverage 95.67% 95.66% -0.02%
==========================================
Files 317 317
Lines 16750 16750
==========================================
- Hits 16026 16024 -2
- Misses 571 572 +1
- Partials 153 154 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
why is this needed? what problem does it solve? |
@yurishkuro This PR is part of #6278 which aims to collect metrics snapshots from all E2E integration test workflows for backwards compatibility tracking. The tailsampling integration test already runs the full Jaeger v2 binary with the tail sampling processor active via The tail sampling processor registers its own metrics (e.g. We also updated the storage label from |
Which problem is this PR solving?
Description of the changes
verify-metrics-snapshotaction step toci-e2e-tailsampling.ymltailsampling_test.goto pass"tailsampling"as the storagelabel to
e2eInitialize()instead of"memory", so the snapshot iswritten to
.metrics/metrics_snapshot_tailsampling.txtwith a uniquename that does not conflict with the memory workflow's snapshot
E2EStorageIntegration.scrapeMetrics()ine2e_integration.gothetest just needed the correct label and the workflow step wiring
How was this change tested?
testTailSamplingProccessorusese2eInitialize()fromE2EStorageIntegration, which already callsscrapeMetrics()at cleanupthat call
verify-metrics-snapshotafter the same test frameworkgofmtpasses on all modified Go filesChecklist
make lint testAI Usage in this PR (choose one)
See AI Usage Policy.