Skip to content

feat(ci): add metrics snapshot to tailsampling E2E workflow #8190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hharshhsaini wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(ci): add metrics snapshot to tailsampling E2E workflow #8190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/ci-e2e-tailsampling.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,14 @@ jobs:
run: |
make tail-sampling-integration-test

- uses: ./.github/actions/verify-metrics-snapshot
with:
snapshot: metrics_snapshot_tailsampling
artifact_key: metrics_snapshot_tailsampling

- name: Upload coverage to codecov
uses: ./.github/actions/upload-codecov
with:
files: cover.out
flag: tailsampling-processor

2 changes: 1 addition & 1 deletion cmd/jaeger/internal/integration/tailsampling_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func TestTailSamplingProcessor_EnforcesPolicies(t *testing.T) {
// 3. Read the stored services from the memory store
// 4. Check that the sampled services match what is expected
func (ts *TailSamplingIntegration) testTailSamplingProccessor(t *testing.T) {
ts.e2eInitialize(t, "memory")
ts.e2eInitialize(t, "tailsampling")
ts.generateTraces(t)

var actual []string
Expand Down
Loading