[jsk_kinova_robot] Update README for noetic#1906
Open
Kanazawanaoaki wants to merge 6 commits intojsk-ros-pkg:masterfrom
Open
[jsk_kinova_robot] Update README for noetic#1906Kanazawanaoaki wants to merge 6 commits intojsk-ros-pkg:masterfrom
Kanazawanaoaki wants to merge 6 commits intojsk-ros-pkg:masterfrom
Conversation
mqcmd196
requested changes
Feb 5, 2024
Kanazawanaoaki
force-pushed
the
kinova-noetic
branch
from
70cacaf to
6ad34b5
Compare
mqcmd196
requested changes
Feb 5, 2024
jsk_kinova_robot/README.md
Outdated
| cd ~/kinova_ws/src | ||
| wstool init | ||
| wstool merge https://raw.githubusercontent.com/jsk-ros-pkg/jsk_robot/master/jsk_kinova_robot/kinova.rosinstall | ||
| wstool merge https://raw.githubusercontent.com/Kanazawanaoaki/jsk_robot/kinova-noetic/jsk_kinova_robot/kinova.rosinstall.${ROS_DISTRO} # Please ignore error if kinova.rosinstall.${ROS_DISTRO} does not exist. # We can remove this line after the https://github.com/ros/collada_urdf/pull/44 is merged |
Member
There was a problem hiding this comment.
I think it is okay with like
https://raw.githubusercontent.com/jsk-ros-pkg/jsk_robot/master/jsk_kinova_robot/kinova.rosinstall.${ROS_DISTRO}
| wstool update | ||
| cd ../ | ||
| source /opt/ros/melodic/setup.bash | ||
| source /opt/ros/${ROS_DISTRO}/setup.bash |
Member
There was a problem hiding this comment.
NITS: The environment variable ${ROS_DISTRO} has not been set unless the user source /opt/ros/.../setup.bash . So you had better writing like /opt/ros/noetic/setup.bash # If noetic
Contributor
Author
There was a problem hiding this comment.
I put source /opt/ros/*/setup.bash first because .rosinstall part also uses ${ROS_DISTRO}. 6193b0f
you can use jsk-ros-pkg/master as jsk-ros-pkg/jsk_model_tools#254 was merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README has been updated with the modifications for building the jsk_kinova_robot environment in Noetic, as reported in #1905.