Skip to content

[panda_eus] Support robots under ROS_NAMESPACE#1933

Merged
k-okada merged 2 commits intojsk-ros-pkg:masterfrom
pazeshun:panda-namespace
Mar 10, 2025
Merged

[panda_eus] Support robots under ROS_NAMESPACE#1933
k-okada merged 2 commits intojsk-ros-pkg:masterfrom
pazeshun:panda-namespace

Conversation

@pazeshun
Copy link
Copy Markdown
Contributor

@pazeshun pazeshun commented Mar 1, 2025

This PR enables to move Panda like:

ROS_NAMESPACE=left_panda roslaunch jsk_panda_startup panda.launch robot_ip:=172.16.0.11
ROS_NAMESPACE=left_panda roseus panda-interface.l

to avoid node name collision with other robots (e.g., Cobotta)

@github-actions github-actions bot added the panda dual franka robot in JSK label Mar 1, 2025
@k-okada
Copy link
Copy Markdown
Member

k-okada commented Mar 3, 2025

@pazeshun CI passed. Is this ready for review?

@pazeshun
Copy link
Copy Markdown
Contributor Author

pazeshun commented Mar 4, 2025

We will have an opportunity to test this PR well in the moonshot demo, so I want to keep this PR Draft for now.

@pazeshun pazeshun marked this pull request as ready for review March 9, 2025 09:08
@pazeshun
Copy link
Copy Markdown
Contributor Author

pazeshun commented Mar 9, 2025

Now this PR was tested well on real robots.
@k-okada Could you review this?

@k-okada k-okada merged commit c2e17b7 into jsk-ros-pkg:master Mar 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

panda dual franka robot in JSK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants