Skip to content

License pr#75

Merged
kryptodrex merged 2 commits intomainfrom
license-pr
Mar 23, 2026
Merged

License pr#75
kryptodrex merged 2 commits intomainfrom
license-pr

Conversation

@kryptodrex
Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings March 23, 2026 11:30
@github-actions
Copy link
Copy Markdown

Version File Not Updated

The version file was not modified in this PR. Please update the version file in the root directory with the new version number.

@kryptodrex kryptodrex merged commit 46a69be into main Mar 23, 2026
1 of 5 checks passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates GitHub Actions workflow triggers/filters to reduce CI runs for documentation-only changes and modifies the release workflow to run on pushes to main instead of merged PRs.

Changes:

  • Expanded paths-ignore in multiple workflows to include additional Markdown patterns (including uppercase .MD).
  • Changed release.yml trigger from pull_request (closed) to push on main.
  • Removed job-level if: conditions that previously gated release jobs on PR merge status.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 6 comments.

File Description
.github/workflows/validate-version.yml Adds additional Markdown ignore patterns to avoid running on doc-only PR changes
.github/workflows/test.yml Adds additional Markdown ignore patterns to avoid running on doc-only PR changes
.github/workflows/build.yml Adds additional Markdown ignore patterns to avoid running on doc-only PR changes
.github/workflows/release.yml Switches release trigger to push on main, adds Markdown ignore patterns, removes PR-merge gating conditions

Comment on lines +10 to +13
- '/*.md'
- '**/*.md'
- '*.md'
- '/*.MD'
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paths-ignore patterns starting with a leading slash (e.g., '/*.md', '/*.MD') are likely not matched by GitHub Actions path filtering because file paths are evaluated as repository-relative paths without a leading /. This can cause the workflow to still run when only root-level Markdown files change. Remove the leading-slash patterns (or replace them with the correct repo-relative patterns) so the ignore behavior is reliable.

Suggested change
- '/*.md'
- '**/*.md'
- '*.md'
- '/*.MD'
- '**/*.md'
- '*.md'

Copilot uses AI. Check for mistakes.
Comment on lines +13 to +17
- '/*.md'
- '**/*.md'
- '*.md'
- '/*.MD'
- '**/*.MD'
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Markdown ignore patterns are redundant and harder to maintain across workflows (e.g., both *.md and **/*.md, plus duplicated uppercase variants). Consider consolidating to a smaller set of patterns that covers root + subdirectories and both cases (for example using a single case-insensitive-like glob such as **/*.[mM][dD] plus *.[mM][dD], depending on what your existing patterns already cover). This reduces duplication across workflow files and lowers the chance of inconsistencies.

Suggested change
- '/*.md'
- '**/*.md'
- '*.md'
- '/*.MD'
- '**/*.MD'
- '*.[mM][dD]'
- '**/*.[mM][dD]'

Copilot uses AI. Check for mistakes.
Comment on lines 3 to 6
on:
pull_request:
push:
branches:
- main
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching the workflow trigger to push on main and removing the PR-merge gating means the release workflow will run on every push to main (including direct pushes), not just merged PRs. If publish-release actually publishes artifacts/releases, this is a significant behavior change and may result in unintended releases. Consider restricting the trigger to tags (e.g., version tags), adding a workflow_dispatch manual trigger, or adding a paths: filter / conditional that only publishes when a version/release-related file changes.

Copilot uses AI. Check for mistakes.
@@ -22,7 +23,6 @@ permissions:

jobs:
build:
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching the workflow trigger to push on main and removing the PR-merge gating means the release workflow will run on every push to main (including direct pushes), not just merged PRs. If publish-release actually publishes artifacts/releases, this is a significant behavior change and may result in unintended releases. Consider restricting the trigger to tags (e.g., version tags), adding a workflow_dispatch manual trigger, or adding a paths: filter / conditional that only publishes when a version/release-related file changes.

Copilot uses AI. Check for mistakes.
@@ -93,7 +93,6 @@ jobs:
retention-days: 90

publish-release:
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching the workflow trigger to push on main and removing the PR-merge gating means the release workflow will run on every push to main (including direct pushes), not just merged PRs. If publish-release actually publishes artifacts/releases, this is a significant behavior change and may result in unintended releases. Consider restricting the trigger to tags (e.g., version tags), adding a workflow_dispatch manual trigger, or adding a paths: filter / conditional that only publishes when a version/release-related file changes.

Suggested change
publish-release:
publish-release:
if: startsWith(github.ref, 'refs/tags/v')

Copilot uses AI. Check for mistakes.
@@ -1,15 +1,16 @@
name: Release
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title (\"License pr\") doesn’t match the actual changes here, which are workflow trigger/path-filter changes (including a significant release trigger change). Please update the PR title/description so reviewers understand the intent and the operational impact.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants