Conversation
|
❌ Version File Not Updated The version file was not modified in this PR. Please update the |
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions workflow triggers/filters to reduce CI runs for documentation-only changes and modifies the release workflow to run on pushes to main instead of merged PRs.
Changes:
- Expanded
paths-ignorein multiple workflows to include additional Markdown patterns (including uppercase.MD). - Changed
release.ymltrigger frompull_request(closed) topushonmain. - Removed job-level
if:conditions that previously gated release jobs on PR merge status.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| .github/workflows/validate-version.yml | Adds additional Markdown ignore patterns to avoid running on doc-only PR changes |
| .github/workflows/test.yml | Adds additional Markdown ignore patterns to avoid running on doc-only PR changes |
| .github/workflows/build.yml | Adds additional Markdown ignore patterns to avoid running on doc-only PR changes |
| .github/workflows/release.yml | Switches release trigger to push on main, adds Markdown ignore patterns, removes PR-merge gating conditions |
| - '/*.md' | ||
| - '**/*.md' | ||
| - '*.md' | ||
| - '/*.MD' |
There was a problem hiding this comment.
The paths-ignore patterns starting with a leading slash (e.g., '/*.md', '/*.MD') are likely not matched by GitHub Actions path filtering because file paths are evaluated as repository-relative paths without a leading /. This can cause the workflow to still run when only root-level Markdown files change. Remove the leading-slash patterns (or replace them with the correct repo-relative patterns) so the ignore behavior is reliable.
| - '/*.md' | |
| - '**/*.md' | |
| - '*.md' | |
| - '/*.MD' | |
| - '**/*.md' | |
| - '*.md' |
| - '/*.md' | ||
| - '**/*.md' | ||
| - '*.md' | ||
| - '/*.MD' | ||
| - '**/*.MD' |
There was a problem hiding this comment.
The Markdown ignore patterns are redundant and harder to maintain across workflows (e.g., both *.md and **/*.md, plus duplicated uppercase variants). Consider consolidating to a smaller set of patterns that covers root + subdirectories and both cases (for example using a single case-insensitive-like glob such as **/*.[mM][dD] plus *.[mM][dD], depending on what your existing patterns already cover). This reduces duplication across workflow files and lowers the chance of inconsistencies.
| - '/*.md' | |
| - '**/*.md' | |
| - '*.md' | |
| - '/*.MD' | |
| - '**/*.MD' | |
| - '*.[mM][dD]' | |
| - '**/*.[mM][dD]' |
| on: | ||
| pull_request: | ||
| push: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
Switching the workflow trigger to push on main and removing the PR-merge gating means the release workflow will run on every push to main (including direct pushes), not just merged PRs. If publish-release actually publishes artifacts/releases, this is a significant behavior change and may result in unintended releases. Consider restricting the trigger to tags (e.g., version tags), adding a workflow_dispatch manual trigger, or adding a paths: filter / conditional that only publishes when a version/release-related file changes.
| @@ -22,7 +23,6 @@ permissions: | |||
|
|
|||
| jobs: | |||
| build: | |||
There was a problem hiding this comment.
Switching the workflow trigger to push on main and removing the PR-merge gating means the release workflow will run on every push to main (including direct pushes), not just merged PRs. If publish-release actually publishes artifacts/releases, this is a significant behavior change and may result in unintended releases. Consider restricting the trigger to tags (e.g., version tags), adding a workflow_dispatch manual trigger, or adding a paths: filter / conditional that only publishes when a version/release-related file changes.
| @@ -93,7 +93,6 @@ jobs: | |||
| retention-days: 90 | |||
|
|
|||
| publish-release: | |||
There was a problem hiding this comment.
Switching the workflow trigger to push on main and removing the PR-merge gating means the release workflow will run on every push to main (including direct pushes), not just merged PRs. If publish-release actually publishes artifacts/releases, this is a significant behavior change and may result in unintended releases. Consider restricting the trigger to tags (e.g., version tags), adding a workflow_dispatch manual trigger, or adding a paths: filter / conditional that only publishes when a version/release-related file changes.
| publish-release: | |
| publish-release: | |
| if: startsWith(github.ref, 'refs/tags/v') |
| @@ -1,15 +1,16 @@ | |||
| name: Release | |||
There was a problem hiding this comment.
The PR title (\"License pr\") doesn’t match the actual changes here, which are workflow trigger/path-filter changes (including a significant release trigger change). Please update the PR title/description so reviewers understand the intent and the operational impact.
No description provided.