Skip to content

License pr #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kryptodrex merged 2 commits into from
Mar 23, 2026
Merged

License pr #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09a4a34
added .md to license
kryptodrex Mar 23, 2026
4d4b2ea
fix workflows
kryptodrex Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,11 @@ on:
- reopened
paths-ignore:
- '.github/workflows/**'
- '/*.md'
- '**/*.md'
- '*.md'
- '/*.MD'
- '**/*.MD'
- '.gitignore'
- 'release/**'
- 'dist/**'
Expand Down
9 changes: 4 additions & 5 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
name: Release
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title (\"License pr\") doesn’t match the actual changes here, which are workflow trigger/path-filter changes (including a significant release trigger change). Please update the PR title/description so reviewers understand the intent and the operational impact.

Copilot uses AI. Check for mistakes.

on:
pull_request:
push:
branches:
- main
Comment on lines 3 to 6
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching the workflow trigger to push on main and removing the PR-merge gating means the release workflow will run on every push to main (including direct pushes), not just merged PRs. If publish-release actually publishes artifacts/releases, this is a significant behavior change and may result in unintended releases. Consider restricting the trigger to tags (e.g., version tags), adding a workflow_dispatch manual trigger, or adding a paths: filter / conditional that only publishes when a version/release-related file changes.

Copilot uses AI. Check for mistakes.
types:
- closed
paths-ignore:
- '.github/workflows/**'
- '/*.md'
- '**/*.md'
- '*.md'
- '/*.MD'
- '**/*.MD'
- '.gitignore'
- 'release/**'
- 'dist/**'
Expand All @@ -22,7 +23,6 @@ permissions:

jobs:
build:
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching the workflow trigger to push on main and removing the PR-merge gating means the release workflow will run on every push to main (including direct pushes), not just merged PRs. If publish-release actually publishes artifacts/releases, this is a significant behavior change and may result in unintended releases. Consider restricting the trigger to tags (e.g., version tags), adding a workflow_dispatch manual trigger, or adding a paths: filter / conditional that only publishes when a version/release-related file changes.

Copilot uses AI. Check for mistakes.
if: github.event.pull_request.merged == true && github.event.pull_request.base.ref == 'main'
runs-on: ${{ matrix.os }}
strategy:
matrix:
Expand Down Expand Up @@ -93,7 +93,6 @@ jobs:
retention-days: 90

publish-release:
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching the workflow trigger to push on main and removing the PR-merge gating means the release workflow will run on every push to main (including direct pushes), not just merged PRs. If publish-release actually publishes artifacts/releases, this is a significant behavior change and may result in unintended releases. Consider restricting the trigger to tags (e.g., version tags), adding a workflow_dispatch manual trigger, or adding a paths: filter / conditional that only publishes when a version/release-related file changes.

Suggested change
publish-release:
publish-release:
if: startsWith(github.ref, 'refs/tags/v')

Copilot uses AI. Check for mistakes.
if: github.event.pull_request.merged == true && github.event.pull_request.base.ref == 'main'
needs: build
runs-on: ubuntu-latest

Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,11 @@ on:
- reopened
paths-ignore:
- '.github/workflows/**'
- '/*.md'
- '**/*.md'
- '*.md'
- '/*.MD'
- '**/*.MD'
Comment on lines +13 to +17
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Markdown ignore patterns are redundant and harder to maintain across workflows (e.g., both *.md and **/*.md, plus duplicated uppercase variants). Consider consolidating to a smaller set of patterns that covers root + subdirectories and both cases (for example using a single case-insensitive-like glob such as **/*.[mM][dD] plus *.[mM][dD], depending on what your existing patterns already cover). This reduces duplication across workflow files and lowers the chance of inconsistencies.

Suggested change
- '/*.md'
- '**/*.md'
- '*.md'
- '/*.MD'
- '**/*.MD'
- '*.[mM][dD]'
- '**/*.[mM][dD]'

Copilot uses AI. Check for mistakes.
- '.gitignore'
- 'release/**'
- 'dist/**'
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/validate-version.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,11 @@ on:
types: [opened, synchronize, reopened]
paths-ignore:
- '.github/workflows/**'
- '/*.md'
- '**/*.md'
- '*.md'
- '/*.MD'
Comment on lines +10 to +13
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paths-ignore patterns starting with a leading slash (e.g., '/*.md', '/*.MD') are likely not matched by GitHub Actions path filtering because file paths are evaluated as repository-relative paths without a leading /. This can cause the workflow to still run when only root-level Markdown files change. Remove the leading-slash patterns (or replace them with the correct repo-relative patterns) so the ignore behavior is reliable.

Suggested change
- '/*.md'
- '**/*.md'
- '*.md'
- '/*.MD'
- '**/*.md'
- '*.md'

Copilot uses AI. Check for mistakes.
- '**/*.MD'
- '.gitignore'
- 'release/**'
- 'dist/**'
Expand Down
0 LICENSE → LICENSE.md
View file
Open in desktop
File renamed without changes.
Loading