Wait 60 seconds for DNS TXT record propagation#80
Open
zamaudio wants to merge 1 commit into
Open
Conversation
Also print a useful error message when DNS lookup fails. Signed-off-by: Damien Zammit <damien@zamaudio.com>
Author
|
The DNS-01 challenge seems to only be valid when the TXT record is already propagated. You get an invalid response if you send a dns challenge before the TXT record has propagated and thus never can fulfill the challenge. Therefore a 60 second wait is reasonable for most users, but may need to be longer when the TTL is high. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also print a useful error message when DNS lookup fails.