Skip to content

Wait 60 seconds for DNS TXT record propagation #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zamaudio wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Wait 60 seconds for DNS TXT record propagation #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions acme_nginx/Acme.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,11 +388,15 @@ def _verify_challenge(self, url, domain, directory=None):
self._send_signed_request(url, "", directory)[1]
)
if challenge_status["status"] == "pending":
self.log.info("waiting...")
time.sleep(5)
continue
elif challenge_status["status"] == "valid":
self.log.info("{0} verified!".format(domain))
break
# invalid status could indicate NXDOMAIN on unpropagated dns record
if challenge_status["identifier"]["type"] == "dns" and challenge_status["status"] == "invalid":
self.log.error("DNS challenge failed (did the TXT record fail to propagate in one minute?)")
self.log.error(
"{0} challenge did not pass: {1}".format(domain, challenge_status)
)
Expand Down
3 changes: 3 additions & 0 deletions acme_nginx/AcmeV2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,9 @@ def solve_dns_challenge(self, directory, client):
self.log.error("error creating dns record")
self.log.error(e)
sys.exit(1)

self.log.info("waiting a minute for dns propagation")
time.sleep(60)
try:
self.log.info("asking acme server to verify challenge")
payload = {"keyAuthorization": keyauthorization}
Expand Down