feat: use generateName for PVCs created by Notebook form#843
Open
neo99zhang wants to merge 1 commit intokubeflow:notebooks-v1from
Open
feat: use generateName for PVCs created by Notebook form#843neo99zhang wants to merge 1 commit intokubeflow:notebooks-v1from
neo99zhang wants to merge 1 commit intokubeflow:notebooks-v1from
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
37a7057 to
f528dcf
Compare
Changes the Jupyter Notebook form to use Kubernetes generateName instead
of name when creating new PVCs. This prevents naming conflicts when
notebooks are recreated or when PVCs from deleted notebooks still exist.
Changes:
- createNewPvcFormGroup(): use generateName instead of name
- Default volume names now end with '-' (required for generateName)
- Workspace volume: {notebook-name}-workspace-
- Data volumes: {notebook-name}-datavol-{n}-
Signed-off-by: Feiyu Zhang <feiyuzhang@nianticlabs.com>
Signed-off-by: feiyuzhang <feiyuzhang@nianticlabs.com>
f528dcf to
a97c046
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Changes the Jupyter Notebook form to use Kubernetes
generateNameinstead ofnamewhen creating new PVCs. This prevents naming conflicts when notebooks are recreated or when PVCs from deleted notebooks still exist.Why
Currently, PVCs are created with static names like
{notebook-name}-volume. If a notebook is deleted but the PVC persists (common withRetainreclaim policies or delayed cleanup), recreating a notebook with the same name fails due to PVC naming conflict.Using
generateNameallows Kubernetes to auto-generate unique suffixes, e.g.,mynotebook-volume-x7k2m.Changes
generateNameinstead ofname; default name ends with-{notebook-name}-workspace-{notebook-name}-datavol-{n}-How to test
mynotebook-workspace-x7k2m)Notes
generateNamehandling in createMetadataFormGroupFromPvc already exist, so this change builds on existing infrastructure-as required by KubernetesgenerateNamespecCloses #842