Skip to content

Conversation

@Babbili
Copy link

@Babbili Babbili commented Oct 25, 2025

This PR fixes #34922

This PR migrates from gcr.io/k8s-testimages which is a legacy Google-owned GCR/AR deprecated repo to registry.k8s.io/ a Kubernetes community-owned.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 25, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Babbili
Once this PR has been reviewed and has the lgtm label, please assign dims for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @Babbili!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 25, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @Babbili. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/images area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 25, 2025
@Babbili
Copy link
Author

Babbili commented Oct 25, 2025

also they're other changes for the same gcr.io/k8s-testimages maybe considered in other repositories (kubernetes/pref-tests, ...) , as in here

@Babbili Babbili changed the title Migrate to registry.k8s.io/k8s-testimages repo Migrate to registry.k8s.io Oct 25, 2025
spec:
containers:
- image: gcr.io/k8s-testimages/launcher.gcr.io/google/bazel:latest-kubernetes-master
- image: registry.k8s.io/launcher.gcr.io/google/bazel:latest-kubernetes-master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple substitution like this does not work, this image does not exist.

Please confirm that these images exist.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpanato it kinda looks like we could archive this repo and turn down the CI jobs, no commits since January 2022 ...

Copy link
Author

@Babbili Babbili Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right, i'd push the images that doesn't exist yet, please which project, artifact repo and region, i don't have access to the GCP projects, will i need a serviceaccount key instead or creating a prow job will do it. i found this maybe helpful

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't an image we built, it was copied from launcher.gcr.io/google/bazel, we should avoid building yet another image ourselves, working with the owners of github.com/kubernetes/repo-infra to find a solution.

Perhaps the bazel parts of this repo can be deleted and this replaced with a kubekins-e2e job running make.

We do not have any humans pushing images directly. See https://github.com/kubernetes/registry.k8s.io?tab=readme-ov-file#registryk8sio

spec:
containers:
- image: gcr.io/k8s-testimages/gubernator:v20230111-cd1b3caf9c
- image: registry.k8s.io/gubernator:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this image does not exist.

- [pull-org-test-all] uses `launcher.gcr.io/google/bazel:0.26.0` to run `bazel test //...`

Many jobs use `gcr.io/k8s-testimages/foo` images that are built from source in
Many jobs use `registry.k8s.io/foo` images that are built from source in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many of our CI jobs use staging images, which is an exception to the general guidance to use production published images. These images are not published because they're not intended for external re-use, they're internal to the project.

However, this should point to the community owned project

@BenTheElder
Copy link
Member

cc @kubernetes/sig-k8s-infra-leads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Issues or PRs related to code in /config area/images area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate away from gcr.io/k8s-testimages repo

3 participants