-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Migrate to registry.k8s.io
#35777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Migrate to registry.k8s.io
#35777
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ presubmits: | |
| preset-bazel-scratch-dir: "true" | ||
| spec: | ||
| containers: | ||
| - image: gcr.io/k8s-testimages/launcher.gcr.io/google/bazel:latest-kubernetes-master | ||
| - image: registry.k8s.io/launcher.gcr.io/google/bazel:latest-kubernetes-master | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Simple substitution like this does not work, this image does not exist. Please confirm that these images exist. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @cpanato it kinda looks like we could archive this repo and turn down the CI jobs, no commits since January 2022 ... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you're right, i'd push the images that doesn't exist yet, please which project, artifact repo and region, i don't have access to the GCP projects, will i need a serviceaccount key instead or creating a prow job will do it. i found this maybe helpful There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This isn't an image we built, it was copied from launcher.gcr.io/google/bazel, we should avoid building yet another image ourselves, working with the owners of github.com/kubernetes/repo-infra to find a solution. Perhaps the bazel parts of this repo can be deleted and this replaced with a kubekins-e2e job running make. We do not have any humans pushing images directly. See https://github.com/kubernetes/registry.k8s.io?tab=readme-ov-file#registryk8sio |
||
| command: | ||
| - ./presubmit.sh | ||
| imagePullPolicy: Always | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,7 @@ presubmits: | |
| preset-service-account: "true" | ||
| spec: | ||
| containers: | ||
| - image: gcr.io/k8s-testimages/gubernator:v20230111-cd1b3caf9c | ||
| - image: registry.k8s.io/gubernator:latest | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this image does not exist. |
||
| command: | ||
| - ./gubernator/test-gubernator.sh | ||
| env: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many of our CI jobs use staging images, which is an exception to the general guidance to use production published images. These images are not published because they're not intended for external re-use, they're internal to the project.
However, this should point to the community owned project