fix(ci): resolve syntax and indentation errors breaking upstream main#1668
Open
koushik-gupta wants to merge 3 commits into
Open
fix(ci): resolve syntax and indentation errors breaking upstream main#1668koushik-gupta wants to merge 3 commits into
koushik-gupta wants to merge 3 commits into
Conversation
🎉 Welcome to Hybrid Recommender, @koushik-gupta!Thank you for your first pull request! Here's what happens next:
⏱️ Please respond to any review comments within 48 hours. 📖 Resources: Happy contributing! 🚀 |
|
🎉 Welcome to Hybrid Recommender, @koushik-gupta! This is your first contribution here! Labels added: PR Description Checklist: ✅ PR description looks complete! What happens next:
⏱️ Please respond to review comments within 48 hours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR provides a clean, minimal fix for the remaining upstream syntax and indentation errors that were causing CI pipelines to crash on all new PRs.
Specifically, it fixes:
select_bandit_arminsrc/model/hybrid_model.pythat was causing anIndentationError.IndentationErrorand aNameErrorincelery_app.pyby properly unindenting the Celery configuration and referencingcelery_appinstead of an undefinedappvariable.Why
This directly addresses the issues raised in #1273 that were not fully solved by previous upstream commits. By isolating just these specific fixes on a fresh, synced branch off
main, we avoid the "too many changed files" issue from previous PR attempts.How to test
pytest tests/test_e2e_api_suite.py- the test suite will now pass completely without failing during setup.flake8- no indentation or syntax errors will be reported forhybrid_model.pyorcelery_app.py.Closes #1273