Skip to content

fix(ci): resolve syntax and indentation errors breaking upstream main#1668

Open
koushik-gupta wants to merge 3 commits into
leonagoel:mainfrom
koushik-gupta:fix/issue-1273-ci-failures
Open

fix(ci): resolve syntax and indentation errors breaking upstream main#1668
koushik-gupta wants to merge 3 commits into
leonagoel:mainfrom
koushik-gupta:fix/issue-1273-ci-failures

Conversation

@koushik-gupta

Copy link
Copy Markdown

What changed

This PR provides a clean, minimal fix for the remaining upstream syntax and indentation errors that were causing CI pipelines to crash on all new PRs.

Specifically, it fixes:

  • Removed a rogue Git merge conflict block inside select_bandit_arm in src/model/hybrid_model.py that was causing an IndentationError.
  • Fixed an IndentationError and a NameError in celery_app.py by properly unindenting the Celery configuration and referencing celery_app instead of an undefined app variable.

Why

This directly addresses the issues raised in #1273 that were not fully solved by previous upstream commits. By isolating just these specific fixes on a fresh, synced branch off main, we avoid the "too many changed files" issue from previous PR attempts.

How to test

  1. Checkout this branch.
  2. Run pytest tests/test_e2e_api_suite.py - the test suite will now pass completely without failing during setup.
  3. Run flake8 - no indentation or syntax errors will be reported for hybrid_model.py or celery_app.py.

Closes #1273

@github-actions

Copy link
Copy Markdown

🎉 Welcome to Hybrid Recommender, @koushik-gupta!

Thank you for your first pull request! Here's what happens next:

Step What Who
1 CI runs lint + smoke test 🤖 Automated
2 Code review 👤 @leonagoel
3 mentor:leonagoel label added 👤 Mentor
4 gssoc:approved label added 👤 Mentor
5 Auto-merge triggered 🤖 Automated
6 Points on leaderboard at 4 AM IST 🏆 GSSoC

⏱️ Please respond to any review comments within 48 hours.

📖 Resources:

Happy contributing! 🚀

@github-actions

Copy link
Copy Markdown

🎉 Welcome to Hybrid Recommender, @koushik-gupta! This is your first contribution here!

Labels added: gssoc:approved | mentor:leonagoel | status:review-needed

PR Description Checklist:

YES - What changed section
YES - Why section
YES - How to test section
YES - Related issue linked

✅ PR description looks complete!

What happens next:

  1. @leonagoel will review your changes
  2. CI checks must pass
  3. Once approved, this PR will be auto-merged

⏱️ Please respond to review comments within 48 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Critical: upstream/main failing CI checks due to syntax errors and missing dependencies

1 participant