Skip to content

fix(ci): resolve syntax and indentation errors breaking upstream main #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leonagoel merged 2 commits into from
Jun 28, 2026
Merged

fix(ci): resolve syntax and indentation errors breaking upstream main #1668

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec7e16f
fix(ci): resolve syntax and indentation errors breaking upstream main
koushik-gupta Jun 26, 2026
2de9c19
fix(ci): fix NameError for method and add clamping for k parameter
koushik-gupta Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions backend/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def clean(value, strip=True):

@app.get("/api/evaluate")
async def evaluate_models(
k: int = 10,
k: int = Query(10, ge=1, le=100),
mode: str = "all",
alpha: float = 0.4,
beta: float = 0.35,
Expand Down Expand Up @@ -467,14 +467,14 @@ def _apply_rate_limit(
reset_time = max(0, reset_time)

_prune_rate_limit_buckets(now)
global _request_counter
_request_counter += 1
if _request_counter >= CLEANUP_THRESHOLD:
_request_counter = 0
# Garbage Collection: Remove empty buckets to prevent memory leak
empty_keys = [k for k, v in _rate_limit_buckets.items() if not v]
for k in empty_keys:
del _rate_limit_buckets[k]
global _request_counter
_request_counter += 1
if _request_counter >= CLEANUP_THRESHOLD:
_request_counter = 0
# Garbage Collection: Remove empty buckets to prevent memory leak
empty_keys = [k for k, v in _rate_limit_buckets.items() if not v]
for k in empty_keys:
del _rate_limit_buckets[k]

response.headers["x-ratelimit-limit"] = str(rate_limit)
response.headers["x-ratelimit-remaining"] = str(remaining)
Expand Down Expand Up @@ -2070,7 +2070,8 @@ def get_recommendations(
user_id: Optional[str] = Query(None),
target_catalog: Optional[str] = Query(None),
model_version: Optional[str] = Query(None),
strategy: Optional[str] = Query(None),
strategy: Optional[str] = Query(None),
method: Optional[str] = Query(None, description="knn for KNN-based collaborative filtering"),
):
rate_limited = _apply_rate_limit(
request,
Expand Down
Loading