fix javadoc generation #130
Conversation
| import java.io.IOException; | ||
|
|
||
| import org.puredata.android.service.R; | ||
| import org.puredata.android.service.*; |
There was a problem hiding this comment.
I'm not pretending I fully understand this, but I think the problem comes from R is not defined at the moment javadoc runs. So replacing org.puredata.android.service.R with org.puredata.android.service.* fixes the javadoc issue (that's a hack I found on the net when I tried to fix this).
|
|
||
| PendingIntent pi = PendingIntent.getActivity(getApplicationContext(), 0, intent, PendingIntent.FLAG_IMMUTABLE); | ||
| return new NotificationCompat.Builder(PdService.this, TAG) | ||
| return new Notification.Builder(PdService.this, TAG) |
There was a problem hiding this comment.
What compatibility with old versions is being lost by this change?
There was a problem hiding this comment.
there again, my comprehension is limited...
All I know is javadoc runs successfully with this change, and apps are running normally.
But I believe this Notification thing needs more love anyway (actually I don't see the notification on devices...).
There was a problem hiding this comment.
By the way, here's where the javadoc errors are ignored in CI:
pd-for-android/PdCore/build.gradle
Line 109 in 395ff52
There was a problem hiding this comment.
Of course!
Here I can run locally with failOnError = true
|
superseded by #152 |
These small changes clear errors of javadoc task, which then successfully generates the javadoc pages.