Skip to content

fix javadoc generation #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix javadoc generation #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PdCore/src/main/java/org/puredata/android/io/AudioWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

import java.io.IOException;

import org.puredata.android.service.R;
import org.puredata.android.service.*;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What else is imported?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not pretending I fully understand this, but I think the problem comes from R is not defined at the moment javadoc runs. So replacing org.puredata.android.service.R with org.puredata.android.service.* fixes the javadoc issue (that's a hack I found on the net when I tried to fix this).

import org.puredata.android.utils.Properties;

import android.annotation.TargetApi;
Expand Down
3 changes: 1 addition & 2 deletions PdCore/src/main/java/org/puredata/android/service/PdService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
import android.os.Build;
import android.os.IBinder;
import android.preference.PreferenceManager;
import androidx.core.app.NotificationCompat;
import android.util.Log;

import java.io.File;
Expand Down Expand Up @@ -242,7 +241,7 @@ private Notification makeNotification(Intent intent, int icon, String title, Str
}

PendingIntent pi = PendingIntent.getActivity(getApplicationContext(), 0, intent, PendingIntent.FLAG_IMMUTABLE);
return new NotificationCompat.Builder(PdService.this, TAG)
return new Notification.Builder(PdService.this, TAG)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What compatibility with old versions is being lost by this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there again, my comprehension is limited...
All I know is javadoc runs successfully with this change, and apps are running normally.
But I believe this Notification thing needs more love anyway (actually I don't see the notification on devices...).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, here's where the javadoc errors are ignored in CI:

pd-for-android/PdCore/build.gradle

Line 109 in 395ff52

failOnError = false // TODO: fix javadoc issues

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course!
Here I can run locally with failOnError = true

.setSmallIcon(icon)
.setContentTitle(title)
.setTicker(title)
Expand Down
Loading