-
Notifications
You must be signed in to change notification settings - Fork 93
Updates on midi and build system #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reimplement Midi adapters using Android Midi API, reusing Peter's (from/to)WireConverters coming from: https://github.com/nettoyeurny/btmidi/blob/master/AndroidMidi/src/com/noisepages/nettoyeur/midi/
AGP 8.11.0 gradle 8.13 buildToolsVersion 35.0.0 ndk 27.2.12479018
this allows to make apps independent from PdCore sources, so they can declare pd-core dependency like a maven one.
Thanks for fixing the build! Should the action runner be pinned to ubuntu-24.04 to match the selected ndkVersion? Have compatibility requirements changed? If so, can you list the changes? Any reductions in diffs (e.g. revert gratuitous changes) would be appreciated. |
mainly:
I'd love it! |
Regarding compatibility, I am asking about which devices (android version?) this pd-for-android is compatible with. Are some previously supported devices no longer supported? In other words, has the minimum supported android version changed? I commented on the buildToolsVersion, which is apparently no longer needed: https://github.com/libpd/pd-for-android/pull/150/files#r2203627128 |
@tkirshboim had to bump minimum version from 17 to 28 (which is a huge jump!) two years ago when updating libpd. I think this is because of the |
finally I could find the time. |
This PR is the raw state of my work. Its history could be way cleaner, but I can only submit as is for now.
It includes:
The latter allows to fix the CI build, as well as long standing issues about adding native code externals to Pd in Android apps.
Here is a quick description of the changes:
This has the benefit that now, pd-core dependency is declared by the apps the same as if they were standalone; so they can safely be taken as examples.