-
Notifications
You must be signed in to change notification settings - Fork 54
Update @line/liff to v2.27.2 #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: update-nodejs
Are you sure you want to change the base?
Conversation
| }, | ||
| "resolutions": { | ||
| "@types/minimatch": "^5", | ||
| "glob": "8.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a GitHub comment with the tsc error that led to adding this resolutions setting?
This comment will be helpful when we decide to remove the resolutions setting in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, that makes sense. I’ve added a GitHub comment describing the tsc error. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the explanation.
By the way, when you need to suppress type errors under node_modules, you can also set skipLibCheck to true. This change is not necessary in this pull request, but please consider it if you encounter a similar error in another situation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the information. I’ll keep that in mind for future cases.
| "typescript": "^5.9.3", | ||
| "vite": "^2.7.2" | ||
| }, | ||
| "resolutions": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Workaround for a tsc error caused by the unmaintained devcert package.
Added resolutions in package.json. Can be removed once devcert is replaced.
error TS2688: Cannot find type definition file for 'minimatch'.
The file is in the program because:
Entry point for implicit type library 'minimatch'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| }, | ||
| "resolutions": { | ||
| "@types/minimatch": "^5", | ||
| "glob": "8.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the explanation.
By the way, when you need to suppress type errors under node_modules, you can also set skipLibCheck to true. This change is not necessary in this pull request, but please consider it if you encounter a similar error in another situation.
Upgrade @line/liff to v2.27.2 to address security vulnerabilities. (https://github.com/line/liff-playground/security/dependabot/63)
Note
resolutionsfield in package.json.