Skip to content

Conversation

soranakahara
Copy link

Upgrade @line/liff to v2.27.2 to address security vulnerabilities. (https://github.com/line/liff-playground/security/dependabot/63)

Note

  • devcert is no longer maintained.
  • Added a workaround to fix a TypeScript (tsc) error by using the resolutions field in package.json.

@soranakahara soranakahara requested a review from a team as a code owner October 22, 2025 06:07
},
"resolutions": {
"@types/minimatch": "^5",
"glob": "8.1.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a GitHub comment with the tsc error that led to adding this resolutions setting?
This comment will be helpful when we decide to remove the resolutions setting in the future.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, that makes sense. I’ve added a GitHub comment describing the tsc error. Thank you!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the explanation.
By the way, when you need to suppress type errors under node_modules, you can also set skipLibCheck to true. This change is not necessary in this pull request, but please consider it if you encounter a similar error in another situation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the information. I’ll keep that in mind for future cases.

"typescript": "^5.9.3",
"vite": "^2.7.2"
},
"resolutions": {
Copy link
Author

@soranakahara soranakahara Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workaround for a tsc error caused by the unmaintained devcert package.
Added resolutions in package.json. Can be removed once devcert is replaced.

error TS2688: Cannot find type definition file for 'minimatch'.
  The file is in the program because:
    Entry point for implicit type library 'minimatch'

Copy link
Member

@odanado odanado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

},
"resolutions": {
"@types/minimatch": "^5",
"glob": "8.1.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the explanation.
By the way, when you need to suppress type errors under node_modules, you can also set skipLibCheck to true. This change is not necessary in this pull request, but please consider it if you encounter a similar error in another situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants