Skip to content

Update @line/liff to v2.27.2 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: update-nodejs
Choose a base branch
from
Open

Update @line/liff to v2.27.2 #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"lint": "eslint \"src/**/*.{ts,tsx}\""
},
"dependencies": {
"@line/liff": "2.25.1",
"@line/liff": "2.27.2",
"@line/liff-common-profile-plugin": "0.1.0",
"react": "^17.0.2",
"react-dom": "^17.0.2"
Expand All @@ -26,13 +26,17 @@
"@typescript-eslint/eslint-plugin": "^5.23.0",
"@typescript-eslint/parser": "^5.23.0",
"@vitejs/plugin-react": "^1.0.7",
"devcert": "1.2.0",
"devcert": "1.2.2",
"eslint": "^8.15.0",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-react": "^7.29.4",
"eslint-plugin-react-hooks": "^4.5.0",
"prettier": "^2.6.2",
"typescript": "^4.4.4",
"typescript": "^5.9.3",
"vite": "^2.7.2"
},
"resolutions": {
Copy link
Author

@soranakahara soranakahara Oct 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workaround for a tsc error caused by the unmaintained devcert package.
Added resolutions in package.json. Can be removed once devcert is replaced.

error TS2688: Cannot find type definition file for 'minimatch'.
  The file is in the program because:
    Entry point for implicit type library 'minimatch'

"@types/minimatch": "^5",
"glob": "8.1.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a GitHub comment with the tsc error that led to adding this resolutions setting?
This comment will be helpful when we decide to remove the resolutions setting in the future.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, that makes sense. I’ve added a GitHub comment describing the tsc error. Thank you!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the explanation.
By the way, when you need to suppress type errors under node_modules, you can also set skipLibCheck to true. This change is not necessary in this pull request, but please consider it if you encounter a similar error in another situation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the information. I’ll keep that in mind for future cases.

}
}
Loading