-
Couldn't load subscription status.
- Fork 772
Fix JWT module version and checksum issues #5246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: UJESH2K <[email protected]>
Signed-off-by: UJESH KUMAR YADAV <[email protected]>
|
Please update this branch with main & resolve conflicts |
Signed-off-by: UJESH KUMAR YADAV <[email protected]>
chaoscenter/authentication/go.mod
Outdated
| replace github.com/golang-jwt/jwt/v4 => github.com/golang-jwt/jwt/v4 v4.5.0 | ||
|
|
||
| replace github.com/dgrijalva/jwt-go => github.com/golang-jwt/jwt/v4 v4.5.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since, the version is already updated above, these replace statements shouldn't be required. Please remove & try.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am sorry i updated these changes after you merged the file
do i have to do anything now to help ?
chaoscenter/event-tracker/go.mod
Outdated
| sigs.k8s.io/yaml v1.2.0 // indirect | ||
| ) | ||
|
|
||
| replace github.com/form3tech-oss/jwt/v4 => github.com/golang-jwt/jwt/v4 v4.5.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a indirect dependency, Replacing like this will not work. You may leave it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure ill remove it aswell
|
|
||
| go 1.24.0 | ||
|
|
||
| toolchain go1.23.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes i have removed toolchain part
Signed-off-by: UJESH KUMAR YADAV <[email protected]>
Signed-off-by: UJESH KUMAR YADAV <[email protected]>
Signed-off-by: UJESH KUMAR YADAV <[email protected]>
PR Title: Fix JWT module version and checksum issues
This PR addresses and improves the JWT module integration in the project. The following updates have been made:
Upgraded
github.com/golang-jwt/jwtto v4.5.2Added
replacedirectives ingo.modVerified all modules with
go mod verifyWhy this improvement was needed:
jwt/v4.Impact:
Fixes: #5245