-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore: Enable keyword search for Milvus inline #3073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: Enable keyword search for Milvus inline #3073
Conversation
@franciscojavierarceo a quick one. With this we will have feature parity between inline and remote milvus for search modes. |
Nice! I approved the workflow, let's wait for the tests to pass. |
Shouldn't you update pyproject.toml for the latest release? Or do we already have the latest version that supports bm25? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we must have the latest version. Thanks for the quick turnaround on this!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should really have a constraint on the minimal required version for milvus-lite. +1 on #3073 (comment)
9ef6936
to
8bc2196
Compare
@leseb @franciscojavierarceo The reason Milvus-lite version was updated, was because we are locking |
8bc2196
to
b329f4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm nice!!
b329f4b
to
536581e
Compare
Signed-off-by: Varsha Prasad Narsing <[email protected]>
536581e
to
6ea6fda
Compare
@leseb could we get this merged this, please? We would need it for upcoming release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look reasonable, self-contained, tested, and feedback looks to be addressed. Thanks!
Dismissing since Seb's request was addressed. 👍
What does this PR do?
With milvus-io/milvus-lite#294 - Milvus Lite supports keyword search using BM25. While introducing keyword search we had explicitly disabled it for inline milvus. This PR removes the need for the check, and enables
inline::milvus
for tests.Test Plan
Run llama stack with
inline::milvus
enabled: