-
Notifications
You must be signed in to change notification settings - Fork 8
fix(website, config): update docs for organism with disableConsensusSequence flag and dont allow fasta downloads #5948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a8628eb to
f6abd9d
Compare
|
This PR may be related to: #5947 (InsdcAccessionFull missing error when running Loculus without consensus sequences) |
|
(we should merge this) |
|
same for unaligned organism potentially? |
|
@theosanderson sorry I didnt see you approved - I now fixed the fasta downloads. I also changed this for the dummy-organism now (I hope this wont break the prepro pipeline - lets see!) |
|
nice, yeah, lgtm. If the unaligned organism doesn't work we can just roll that back for now. |
|
(or fix it as you are :) ) |
|
Claude finished @anna-parker's task in 2m 21s —— View job Code Review Complete ✅I've reviewed this PR that updates documentation and prevents FASTA downloads for organisms without consensus sequences. Overall AssessmentThe implementation correctly addresses the issue by conditionally hiding FASTA download options based on whether reference genomes are configured. The approach is sound, but there are some areas for improvement regarding performance, testing, and code clarity. Key FindingsTesting Coverage
|
website/src/components/SequenceDetailsPage/SequencesDataTableTitle.astro
Outdated
Show resolved
Hide resolved
probably good to look over final ver
theosanderson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
resolves #5947
Screenshot
PR Checklist
🚀 Preview: https://disableconsensussequences.loculus.org