Add Settings menu and Multiplayer SuperStrength #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Settings menu entries done by copying the entries of other settings. Same goes for multiplayer settings (Multiplayer Settings are still untested, I had nobody to test them with ^^) Multiplayer SuperStrength done by magic. Translation only updated for german and english.
Contributor
Author
|
I think the ToggleSawdustEvent might need to be extended for the other serverOnly settings, so that the maxWoodchips and the foliage delete area get synced as well. |
Contributor
Author
|
Known issue: Mouseover of a LumberJack setting does not hide the tooltip of the previously selected option. No technical issue with that as far as I could see though, only visual. |
loki79uk
added a commit
that referenced
this pull request
Nov 25, 2024
So much thanks to Shad0wlife for this, but ESPECIALLY for sorting out the menu!! Updated other language files too. Used DeepL for the missing translations.
When reconnecting to the server, the superstrength didn't work anymore until the server was restarted. Fixed by getting the player variable on the client in a different way. Also fixed the "hand icon"/pickup distance being inverted to the super strength. This was caused by the spec's distance variable only being updated after superstrength was activated. Fixed by ignoring the spec's distance variable and setting the values directly from lumberjack. This means that actually using the command now might break things?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settings menu entries done by copying the entries of other settings.
Same goes for multiplayer settings (Multiplayer Settings are still untested, I had nobody to test them with ^^)
Multiplayer SuperStrength: done by magic.
Translation only updated for german and english.