Do not store file extensions in module chunknames [Luau CLI]#1772
Merged
Do not store file extensions in module chunknames [Luau CLI]#1772
Conversation
aatxe
approved these changes
Apr 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Luau CLI's require implementation was moved to the new
Luau.Requirelibrary in release 0.669.In this implementation, chunknames correspond to abstract module paths (not exact filesystems paths), and this is enforced throughout the require-by-string algorithm whenever a newly required module's chunkname is created. The only place this is not being enforced is at the entry point of the Luau CLI: the chunkname of the given file still includes its file extension, which breaks the invariant expected by the require-by-string implementation.
This PR removes that file extension from the entry point's chunkname.
Fixes #1771.