Fixed Parallax Nexus - when finish cards not come back to opponent hand #13818
Conversation
|
Can this be merged? |
|
|
||
| // When Parallax Nexus leaves the battlefield, each player returns to their hand all cards they own exiled with Parallax Nexus. | ||
| this.addAbility(new LeavesBattlefieldTriggeredAbility(new ReturnFromExileEffect(Zone.HAND).setText("each player returns to their hand all cards they own exiled with {this}"), false)); | ||
| this.addAbility(new LeavesBattlefieldTriggeredAbility(new ReturnFromExileForSourceEffect(Zone.HAND).setText("each player returns to their hand all cards they own exiled with {this}"), false)); |
There was a problem hiding this comment.
Must be carefully checked for blinked permanent (must not see exiled cards after blink, but must see new cards).
There was a problem hiding this comment.
It seems to me like ReturnFromExileForSourceEffect and ReturnFromExileEffect are almost identical, with the main difference being the former allowing for the use of the permanentLeftBattlefield value to account for it being in a LeavesBattlefieldTriggeredAbility. There is potential for a refactor to combine the two, but that'd be something separate.
However, I do agree that it would be good to add a test or two for this to make sure a similar bug doesn't happen again.
There was a problem hiding this comment.
There are some other issues with exile I'm currently trying to understand.
e.g. #13900
Maybe a refactoring of the mechanic is indeed a good solution to clean it up.
JayDi85
changed the title
|
see #13345 |
4 participants
fixes first issue mentioned in #13324