Skip to content

Fixed Parallax Nexus - when finish cards not come back to opponent hand #13818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed Parallax Nexus - when finish cards not come back to opponent hand #13818

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1298c6a
return cards from exile fixed
ThorstenHacke Jul 2, 2025
ac198a7
remove unused import
ThorstenHacke Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Mage.Sets/src/mage/cards/p/ParallaxNexus.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import mage.abilities.common.LeavesBattlefieldTriggeredAbility;
import mage.abilities.costs.common.RemoveCountersSourceCost;
import mage.abilities.effects.common.ExileFromZoneTargetEffect;
import mage.abilities.effects.common.ReturnFromExileEffect;
import mage.abilities.effects.common.ReturnFromExileForSourceEffect;
import mage.abilities.keyword.FadingAbility;
import mage.cards.CardImpl;
import mage.cards.CardSetInfo;
Expand Down Expand Up @@ -37,7 +37,7 @@ public ParallaxNexus(UUID ownerId, CardSetInfo setInfo) {
this.addAbility(ability);

// When Parallax Nexus leaves the battlefield, each player returns to their hand all cards they own exiled with Parallax Nexus.
this.addAbility(new LeavesBattlefieldTriggeredAbility(new ReturnFromExileEffect(Zone.HAND).setText("each player returns to their hand all cards they own exiled with {this}"), false));
this.addAbility(new LeavesBattlefieldTriggeredAbility(new ReturnFromExileForSourceEffect(Zone.HAND).setText("each player returns to their hand all cards they own exiled with {this}"), false));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be carefully checked for blinked permanent (must not see exiled cards after blink, but must see new cards).

IMG_1769

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me like ReturnFromExileForSourceEffect and ReturnFromExileEffect are almost identical, with the main difference being the former allowing for the use of the permanentLeftBattlefield value to account for it being in a LeavesBattlefieldTriggeredAbility. There is potential for a refactor to combine the two, but that'd be something separate.

However, I do agree that it would be good to add a test or two for this to make sure a similar bug doesn't happen again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some other issues with exile I'm currently trying to understand.
e.g. #13900
Maybe a refactoring of the mechanic is indeed a good solution to clean it up.

}

private ParallaxNexus(final ParallaxNexus card) {
Expand Down