bootutil: Extract common loader functions #2503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchy
force-pushed
the
feature/bootutil/NCSDK-NONE_Rework_common_modules
branch
12 times, most recently
from
0f0d586 to
b1509d1
Compare
tomchy
requested review from
almir-okato,
d3zd3z,
davidvincze,
de-nordic and
nordicjm
as code owners
tomchy
force-pushed
the
feature/bootutil/NCSDK-NONE_Rework_common_modules
branch
from
b1509d1 to
57054e9
Compare
de-nordic
reviewed
Oct 21, 2025
tomchy
force-pushed
the
feature/bootutil/NCSDK-NONE_Rework_common_modules
branch
from
57054e9 to
46b5f9d
Compare
de-nordic
approved these changes
Oct 21, 2025
almir-okato
approved these changes
Oct 23, 2025
Rename boot_version_cmp(..) to boot_compare_version(..). Reason: most of the boot APIs use verb as the second part of the function name. Signed-off-by: Tomasz Chyrowicz <[email protected]>
The boot_check_header_erased(..) function may use a common function to check for a buffer value (bootutil_buffer_is_erased). Checking function should return bool intead of int. Signed-off-by: Tomasz Chyrowicz <[email protected]>
Rename boot_is_header_valid(..) to boot_check_header_valid(..). The fap and hdr arguments are misleading - they should always point to the same slot. Change the function signature to use slot number instead. Signed-off-by: Tomasz Chyrowicz <[email protected]>
Rename boot_image_check(..) to boot_check_image(..). Most of boot APIs use verb as the second part of the function name. The fap and hdr arguments are misleading - they should always point to the same slot. Change the function signature to use slot number instead. Signed-off-by: Tomasz Chyrowicz <[email protected]>
Add missing API docs for the following functions: - boot_get_loader_state() - boot_get_image_max_sizes() - image_max_size *boot_get_max_app_size() Restrict visibility of the app_size* APIs, based on the configuration. Signed-off-by: Tomasz Chyrowicz <[email protected]>
Move functions, that operate on the flash area and does not require the bootloader state or bootloader status into a separate, dedicated file. Signed-off-by: Tomasz Chyrowicz <[email protected]>
Move the boot_get_max_app_size(..) API into bootutil_misc.c as this file has the remaining functions, that operate on the size array (i.e. boot_fetch_slot_state_sizes(..)) and is independent from the update type, thus moving it will reduce the code duplication in the future. Signed-off-by: Tomasz Chyrowicz <[email protected]>
Move functions from loader.c that are independent from the update type into a dedicated file. That way it will be easier to provide alternative loader type without massive code duplication. This file is intended to be used by loader-like files instead and should not be included in the bootutil/_priv.h headers. Signed-off-by: Tomasz Chyrowicz <[email protected]>
tomchy
force-pushed
the
feature/bootutil/NCSDK-NONE_Rework_common_modules
branch
from
46b5f9d to
1b4be75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the size of loader.c as well as bootutil_misc.c files by extracting common functions into a separate files.