Skip to content

Conversation

mattheweshleman
Copy link

Per note in LinkedIn from François Baldassari, pull request for additions to the schematic review checklist, GPIO section.

@mattheweshleman mattheweshleman requested a review from a team as a code owner July 26, 2025 14:06
@gminn
Copy link
Member

gminn commented Jul 28, 2025

@mattheweshleman thank you for sharing these extra items! I'd like to check with the original author @schultetwin first before we add these. Mark, let us know what you think of adding these checks to the GPIO schematic review section

Copy link
Contributor

@schultetwin schultetwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the additions! I left some comments inline. Happy to talk through them.

Comment on lines 219 to 224
- [x] If the target microcontroller constraints allow for it, are some GPIO pins
assigned for arbitrary firmware development, measurements and debug
purposes? [6](https://covemountainsoftware.com/2016/12/27/brother-can-you-spare-a-gpio/)
- [x] Subject to board layout constraints, are the debug GPIOs routed to
test points that may be connected to an o-scope or other common
tools with minimal risk to the PCB or personnel?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition. What do you think about moving this to the Debug/Test infrastructure section? (And maybe leave a one-line note here?)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@gminn
Copy link
Member

gminn commented Aug 18, 2025

@mattheweshleman Checking in to see if you had the chance to review @schultetwin's recommendations. I'd love to get these additions merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants