-
Notifications
You must be signed in to change notification settings - Fork 144
Additions to the schematic review checklist, GPIO section. #594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Additions to the schematic review checklist, GPIO section. #594
Conversation
@mattheweshleman thank you for sharing these extra items! I'd like to check with the original author @schultetwin first before we add these. Mark, let us know what you think of adding these checks to the GPIO schematic review section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the additions! I left some comments inline. Happy to talk through them.
- [x] If the target microcontroller constraints allow for it, are some GPIO pins | ||
assigned for arbitrary firmware development, measurements and debug | ||
purposes? [6](https://covemountainsoftware.com/2016/12/27/brother-can-you-spare-a-gpio/) | ||
- [x] Subject to board layout constraints, are the debug GPIOs routed to | ||
test points that may be connected to an o-scope or other common | ||
tools with minimal risk to the PCB or personnel? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great addition. What do you think about moving this to the Debug/Test infrastructure section? (And maybe leave a one-line note here?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
@mattheweshleman Checking in to see if you had the chance to review @schultetwin's recommendations. I'd love to get these additions merged! |
Co-authored-by: Mark Schulte <[email protected]>
Per note in LinkedIn from François Baldassari, pull request for additions to the schematic review checklist, GPIO section.