-
Notifications
You must be signed in to change notification settings - Fork 145
Additions to the schematic review checklist, GPIO section. #594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gminn
merged 3 commits into
memfault:master
from
mattheweshleman:eshleman/schematic-review-checklist-gpio-edit
Sep 5, 2025
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -204,10 +204,24 @@ Given these experiences, I have compiled the following list: | |
| - [x] Provide a GPIO map in a spreadsheet, with main function after reset, | ||
| intended function, and any additional notes. | ||
| - [x] Are all MCU peripherals used only once? | ||
| - [x] Are all MCU peripherals mapped in manner to avoid any MCU-specific pin | ||
| sharing constraints? | ||
| - [x] Are all MCU peripherals requiring other MCU resources, such as DMA | ||
| or timers, mapped in a manner that avoids internal MCU sharing conflicts? | ||
| Example: a particular SPI bus may require exacting transaction timing, | ||
| which requires an MCU timer to initiate a DMA transaction on the particular | ||
| SPI bus. Is that device's SPI bus mapped in manner that avoids internal MCU | ||
| resource sharing constraints? | ||
| - [x] If the MCU is held in reset, are the peripheral devices held in their | ||
| proper state? (Pull-up/pull-downs where needed) | ||
| - [x] Does the reset line have a proper pull-up or pull-down? (This is a common | ||
| failure, so worth noting). | ||
| - [x] If the target microcontroller constraints allow for it, are some GPIO pins | ||
| assigned for arbitrary firmware development, measurements and debug | ||
| purposes? [6](https://covemountainsoftware.com/2016/12/27/brother-can-you-spare-a-gpio/) | ||
| - [x] Subject to board layout constraints, are the debug GPIOs routed to | ||
| test points that may be connected to an o-scope or other common | ||
| tools with minimal risk to the PCB or personnel? | ||
|
||
| - [x] Are the debug GPIOs used _only_ for debug purposes? | ||
|
|
||
| ### Busses | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.