-
Notifications
You must be signed in to change notification settings - Fork 23
🌱 Add FKAS build to PR checks #1102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add FKAS build to PR checks #1102
Conversation
prow/config/jobs/metal3-io/cluster-api-provider-metal3-release-1.10.yaml
Outdated
Show resolved
Hide resolved
prow/config/jobs/metal3-io/cluster-api-provider-metal3-release-1.10.yaml
Outdated
Show resolved
Hide resolved
dafcb95 to
45a555f
Compare
45a555f to
81888b4
Compare
|
What's the status with this and the Github workflows? This is not needed right? |
|
I think this is ready to merge. This adds fkas image building as one check that PRs run. I think it's enough to have the check on the main branch and future release branches. It would require some changes to the CAPM3 release branches to make this work on them and this is why I've oped to add the build test only on main branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/hold
for one more fix.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: peppi-lotta <[email protected]>
81888b4 to
f3cd390
Compare
|
/override metal3-ubuntu-e2e-integration-test-main |
|
@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
@peppi-lotta: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Add FKAS build to PR checks runs when something changes under
./hack/fake-apiserverfile.Related PR: metal3-io/cluster-api-provider-metal3#2814