Skip to content

Conversation

@peppi-lotta
Copy link
Member

Add FKAS build to PR checks runs when something changes under ./hack/fake-apiserver file.
Related PR: metal3-io/cluster-api-provider-metal3#2814

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 19, 2025
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/add-fkas-build-pr-check branch 3 times, most recently from dafcb95 to 45a555f Compare October 3, 2025 07:19
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/add-fkas-build-pr-check branch from 45a555f to 81888b4 Compare October 6, 2025 10:58
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 6, 2025
@tuminoid
Copy link
Member

tuminoid commented Oct 9, 2025

What's the status with this and the Github workflows? This is not needed right?

@peppi-lotta
Copy link
Member Author

I think this is ready to merge. This adds fkas image building as one check that PRs run. I think it's enough to have the check on the main branch and future release branches. It would require some changes to the CAPM3 release branches to make this work on them and this is why I've oped to add the build test only on main branch.

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold
for one more fix.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2025
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2025
Signed-off-by: peppi-lotta <[email protected]>
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/add-fkas-build-pr-check branch from 81888b4 to f3cd390 Compare October 16, 2025 06:59
@tuminoid
Copy link
Member

/override metal3-ubuntu-e2e-integration-test-main
/cc @lentzi90
/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2025
@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main
/cc @lentzi90
/unhold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2025
@metal3-io-bot metal3-io-bot merged commit 775f150 into metal3-io:main Oct 20, 2025
6 checks passed
@metal3-io-bot metal3-io-bot deleted the peppi-lotta/add-fkas-build-pr-check branch October 20, 2025 05:53
@metal3-io-bot
Copy link
Collaborator

@peppi-lotta: Updated the job-config configmap in namespace prow at cluster default using the following files:

  • key cluster-api-provider-metal3.yaml using file prow/config/jobs/metal3-io/cluster-api-provider-metal3.yaml

In response to this:

Add FKAS build to PR checks runs when something changes under ./hack/fake-apiserver file.
Related PR: metal3-io/cluster-api-provider-metal3#2814

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants