Update pain.008.001.02.hbs to handle empty / unfound BIC#20
Open
NevenSubotic wants to merge 1 commit intomgmco:masterfrom
Open
Update pain.008.001.02.hbs to handle empty / unfound BIC#20NevenSubotic wants to merge 1 commit intomgmco:masterfrom
NevenSubotic wants to merge 1 commit intomgmco:masterfrom
Conversation
fix to pass certification for transactions without BIC.
NevenSubotic
changed the title
henkkh
reviewed
Dec 27, 2020
| <FinInstnId> | ||
| {{#if bic}} | ||
| <BIC>{{bic}}</BIC> | ||
| {{else}} |
There was a problem hiding this comment.
This is a good change! My initial version only support BIC. But this is also allowed according the pain 008.001.02.xsd. And apparantly it is filled with NOTPROVIDED in that case.
Could be in some countries (Germany?) BIC is always expected though. But this will definitely work in the Netherlands e.g.
Author
There was a problem hiding this comment.
In my case, yes, I am working out of Germany and collecting donations from bank accounts in germany. The BIC is only required on SEPA-Payments out of country, e.g. Netherlands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix to pass certification for transactions without BIC. This kept me from uploading my file due to a validation error.