Skip to content

Update pain.008.001.02.hbs to handle empty / unfound BIC #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NevenSubotic wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update pain.008.001.02.hbs to handle empty / unfound BIC #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions formats/pain.008.001.02.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,16 @@
<DtOfSgntr>{{mandateSignatureDate}}</DtOfSgntr>
<AmdmntInd>false</AmdmntInd>
</MndtRltdInf>
</DrctDbtTx>
{{#if bic}}
</DrctDbtTx>
<DbtrAgt>
<FinInstnId>
{{#if bic}}
<BIC>{{bic}}</BIC>
{{else}}
Copy link
Copy Markdown

@henkkh henkkh Dec 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change! My initial version only support BIC. But this is also allowed according the pain 008.001.02.xsd. And apparantly it is filled with NOTPROVIDED in that case.
Could be in some countries (Germany?) BIC is always expected though. But this will definitely work in the Netherlands e.g.

Copy link
Copy Markdown
Author

@NevenSubotic NevenSubotic Dec 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my case, yes, I am working out of Germany and collecting donations from bank accounts in germany. The BIC is only required on SEPA-Payments out of country, e.g. Netherlands.

<Othr>
<Id>NOTPROVIDED</Id>
</Othr>
{{/if}}
</FinInstnId>
</DbtrAgt>
{{/if}}
Expand All @@ -87,4 +92,4 @@
{{/each}}
</PmtInf>
</CstmrDrctDbtInitn>
</Document>
</Document>