net_mana: downgrading invalid OOB traces from ERROR to WARN #2163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR downgrading invalid OOB traces from ERROR to WARN in the net_mana networking driver. The change addresses excessive error logging for CQE_TX_INVALID_OOB events, which are common and only affect individual packets rather than indicating critical system issues.
Key Changes
- Modified tracing level for CQE_TX_INVALID_OOB from ERROR to WARN to reduce log noise
- Added new
event_ratelimitedmacro to tracelimit for dynamic log level dispatch - Enhanced testing coverage with new validation tests for both valid packets and error handling
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| vm/devices/net/net_mana/src/lib.rs | Refactored trace_tx_error to trace_tx with dynamic level, added BackendQueueStats implementation, and enhanced test coverage |
| vm/devices/net/net_backend/src/lib.rs | Added BackendQueueStats trait and queue_stats method to Queue trait |
| vm/devices/net/net_backend/Cargo.toml | Added inspect_counters dependency |
| vm/devices/net/gdma/src/bnic.rs | Added LSO validation with error handling and completion posting |
| vm/devices/net/gdma/Cargo.toml | Added tracelimit dependency |
| support/tracelimit/src/lib.rs | Added event_ratelimited macros for dynamic log level dispatch |
mattkur
approved these changes
Oct 14, 2025
smalis-msft
requested changes
Oct 14, 2025
smalis-msft
approved these changes
Oct 14, 2025
erfrimod
added
the
backport_2505
erfrimod
added a commit
to erfrimod/openvmm_fork2
that referenced
this pull request
Oct 14, 2025
…t#2163) Not a clean cherry-pick due to changes in tracing WQE handling in net_mana/src/lib.rs Cherry-pick of microsoft#2163
erfrimod
added a commit
that referenced
this pull request
Oct 15, 2025
|
Backported in #2170 |
benhillis
added
backported_2505
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
net_mana::tx_pollreceives an CQE_TX_INVALID_OOB it is currently logged as an Error. These events occur when the metadata does not match how HW parsed the packet. They can be a result of a Guest Bug, HW Bug, or OpenHCL Bug. They are common, possibly due to Encap, and only effect the specific packet. Unfortunately, their frequency is causing confusion when triaging other issues as it is not clear thatty: 35akaCQE_TX_INVALID_OOBis safe to ignore. Downgrading the tracing to Warning to help folks better understand invalid OOB issues are probably not the cause of whatever they're seeing.