Skip to content

Conversation

@erfrimod
Copy link
Contributor

@erfrimod erfrimod commented Oct 14, 2025

Not a clean cherry-pick due to changes in tracing WQE handling in net_mana/src/lib.rs

Backport of #2163

…t#2163)

Not a clean cherry-pick due to changes in tracing WQE handling in net_mana/src/lib.rs

Cherry-pick of microsoft#2163
@erfrimod erfrimod requested a review from a team as a code owner October 14, 2025 22:21
@Copilot Copilot AI review requested due to automatic review settings October 14, 2025 22:21
@erfrimod erfrimod requested a review from a team as a code owner October 14, 2025 22:21
@github-actions github-actions bot added the release_2505 Targets the release/2505 branch. label Oct 14, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR downgrades invalid out-of-band (OOB) TX completion traces from ERROR to WARN level in the MANA network device driver. The change improves handling of invalid OOB metadata errors by treating them as non-critical warnings since they typically occur due to encapsulation and only affect individual packets.

  • Adds CQE_TX_INVALID_OOB error type handling with WARN-level tracing instead of ERROR
  • Introduces dynamic tracing level support with new event_ratelimited macros
  • Adds comprehensive queue statistics reporting and testing infrastructure

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
vm/devices/net/net_mana/src/lib.rs Main changes - adds CQE_TX_INVALID_OOB handling, implements BackendQueueStats trait, refactors tracing functions, and adds comprehensive test coverage
vm/devices/net/net_backend/src/lib.rs Defines BackendQueueStats trait for standardized queue statistics reporting
vm/devices/net/gdma/src/bnic.rs Adds LSO validation logic with error completion posting for improved packet handling
support/tracelimit/src/lib.rs Implements dynamic tracing level macros for runtime log level determination
vm/devices/net/net_mana/Cargo.toml Adds inspect_counters dependency for statistics support
vm/devices/net/net_backend/Cargo.toml Adds inspect_counters dependency
vm/devices/net/gdma/Cargo.toml Adds tracelimit dependency for error logging

@erfrimod erfrimod merged commit b865c49 into microsoft:release/2505 Oct 15, 2025
24 checks passed
@erfrimod erfrimod deleted the erfrimod/netvsp-2163-on-2505 branch October 22, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_2505 Targets the release/2505 branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants