Changing DAXLib update to add_or_update#1079
Open
edwardpcharles wants to merge 1 commit intomicrosoft:mainfrom
Open
Changing DAXLib update to add_or_update#1079edwardpcharles wants to merge 1 commit intomicrosoft:mainfrom
edwardpcharles wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Renamed function from 'update_package_in_semantic_model' to 'add_or_update_package_in_semantic_model' and removed package existence for update. Right now, I am having to use the TOM package to see if package exists and then go add or update which looking at the source code seems to be a bit duplicative. I do not think someone will call an update function on a semantic model if they don't want the semantic model to have the function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed function from 'update_package_in_semantic_model' to 'add_or_update_package_in_semantic_model' and removed package existence check for update.
Right now, I am having to use the TOM package to see if package exists and then go add or update which looking at the source code seems to be a bit duplicative.
I do not think someone will call an update function on a semantic model if they don't want the semantic model to have the function.