Skip to content

Changing DAXLib update to add_or_update #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edwardpcharles wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Changing DAXLib update to add_or_update #1079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/sempy_labs/daxlib/_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,14 +214,6 @@ def package_exists(tom, package_name: str) -> bool:
)
return

if method != "add" and not exists:
print(
f"{icons.info} The '{package_name}' package is not detected in the "
f"semantic model. Please use the 'add_package_to_semantic_model' "
f"function to add it first."
)
return

# add / update logic (shared); First remove existing functions from the package if they exist
for f in tom.model.Functions:
if f.Name.lower().startswith(f"{package_name.lower()}."):
Expand Down Expand Up @@ -311,7 +303,7 @@ def remove_package_from_semantic_model(


@log
def update_package_in_semantic_model(
def add_or_update_package_in_semantic_model(
dataset: str | UUID,
package_name: str,
version: str = None,
Expand Down