fix: address Copilot code review feedback#268
Merged
Conversation
- Remove debug console.log that leaks internal l10n details - Fix i18n-ally.localesPaths to point to correct l10n directory - Replace shell find command with cross-platform glob.sync for Windows compatibility - Fix typo: 'to to considered' → 'to be considered' - Fix grammar: 'look like' → 'looks' - Fix typo: '.e.g' → 'e.g.' Resolves all issues identified in PR #263 Copilot review.
Fixes error: @types/vscode ^1.110.0 greater than engines.vscode ^1.73.0 Changed @types/vscode from ^1.110.0 to ^1.73.0 to match the minimum supported VS Code version. This prevents accidentally using APIs that aren't available in VS Code 1.73.0.
Update yarn.lock to reflect @types/vscode ^1.73.0 -> 1.77.0 (resolves to latest patch that satisfies ^1.73.0 constraint)
Remove TreeCheckboxChangeEvent from MockTreeView because this type is not available in @types/vscode 1.73.x. Keeps tests compatible with the pinned engine/type baseline used by CI.
🚀 Preview Build Ready!A preview build has been generated for this PR. You can download and test it: 📦 Download: pr-preview-268.zip Installation Instructions:
Build: 9937d27 • View workflow run |
Avoid direct TreeCheckboxChangeEvent import (not available in 1.73 typings) while still providing onDidChangeCheckboxState for newer TreeView interfaces.
🚀 Preview Build Ready!A preview build has been generated for this PR. You can download and test it: 📦 Download: pr-preview-268.zip Installation Instructions:
Build: 7ef8a74 • View workflow run |
Lock vscode typings to an exact version matching the current engine baseline to avoid environment-dependent API drift. We can bump engine + typings together in a later change.
🚀 Preview Build Ready!A preview build has been generated for this PR. You can download and test it: 📦 Download: pr-preview-268.zip Installation Instructions:
Build: e532720 • View workflow run |
🚀 Preview Build Ready!A preview build has been generated for this PR. You can download and test it: 📦 Download: pr-preview-268.zip Installation Instructions:
Build: edcb401 • View workflow run |
🚀 Preview Build Ready!A preview build has been generated for this PR. You can download and test it: 📦 Download: pr-preview-268.zip Installation Instructions:
Build: 2245c4b • View workflow run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses all issues identified in PR #263 Copilot review:
✅ Remove debug console.log (lines 369-374 in foldersCompareProvider.ts)
✅ Fix i18n-ally.localesPaths (.vscode/settings.json)
"src/locales"to"l10n"to match actual directory structure✅ Cross-platform validation script (scripts/validate-l10n.js)
findcommand withglob.sync()for Windows compatibility✅ Fix typos and grammar (package.nls.json)
Closes review comments from #263