[code-infra] Add --watch option to build:types #45547
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janpot
added
the
scope: code-infra
github-actions
bot
added
the
PR: out-of-date
Netlify deploy previewhttps://deploy-preview-45547--material-ui.netlify.app/ Bundle size report |
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
DenisCor
reviewed
Apr 9, 2025
| const watcher = fs.watch(sourceDirectory, { recursive: true }); | ||
| for await (const event of watcher) { | ||
| if (event.filename?.endsWith('.d.ts')) { | ||
| handleChange(event.filename); |
There was a problem hiding this comment.
consider normalizing path.resolve(sourceDirectory, event.filename), windows uses \, unix /, path.resolve() ensures you're using the correct format for the current OS
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure this works with the new type generation